Last modified: 2010-05-15 15:28:09 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T3040, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 1040 - GET request with &action=submit not rejected as error
GET request with &action=submit not rejected as error
Status: RESOLVED WORKSFORME
Product: MediaWiki
Classification: Unclassified
General/Unknown (Other open bugs)
1.3.x
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
http://test.wikipedia.org/w/wiki.phtm...
:
Depends on:
Blocks: 335
  Show dependency treegraph
 
Reported: 2004-12-08 21:33 UTC by xmlizer
Modified: 2010-05-15 15:28 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description xmlizer 2004-12-08 21:33:02 UTC
when you open a page that doesn't exist it feels it with the content of
[[MediaWiki:Newarticletext]]
Comment 1 T. Gries 2004-12-08 22:33:27 UTC
I again propose my algorithm as in bugzilla 883. 

Basically it goes like that:

When no exact matching page title is found, all approximate matching page titles
shall be listed to the user to select the page title from - he probably wanted
(see AGREP option -By on http://www.tgries.de/agrep) and on that screen with the
* matching titles show him [[MediaWiki:Newarticletext]].

As soon as I have finished Enotif, I commit myself to the task of programming my
proposal !
Comment 2 Brion Vibber 2004-12-09 00:25:10 UTC
The summary and initial comment of this bug are very unclear. Please 
reopen and explain in more detail what you mean, including steps to 
reproduce and a description of how the actual behavior differs from 
the expected behavior.

Removing seemingly unrelated dependency.
Comment 3 xmlizer 2004-12-09 23:10:58 UTC
ok sorry
i put an example in URL
http://test.wikipedia.org/w/wiki.phtml?title=SUPERBLADOESNTEXIST231239041&action=submit

when you access directly to such a page by a constructed URL
http://test.wikipedia.org/w/wiki.phtml?title=SUPIDNAME&action=submit

you become in edit mode, but the content of the page, which have to be empty, is
the content of [[MediaWiki:Newarticletext]]. 
Comment 4 River Tarnell 2004-12-09 23:19:29 UTC
You can't make up random URLs and expect them to work in some particular way. 
action=submit URLs should only occur on form submission (save/preview).
Comment 5 Brion Vibber 2004-12-10 00:41:02 UTC
Okay, now I see what you mean.

Doing a GET request with action=submit seems to trigger an edit preview with the 
current page text. On a non-existing page it behaves a little more oddly, like an 
edit page with the old no-text text stuck in.

This is incorrect behavior, as doing an action=submit with a GET request is 
undefined. If not a POST, this should probably be rejected with an error message. 
Related to bug 335.

Comment 6 Philippe Elie 2004-12-10 00:56:21 UTC
There is another way it can occur, this catched me sometime ago, slave was
lagging, I needed to revert some vandalism, going to history click on revision
alt-E alt-S but I didn't noticed the edit text was filled with the error message
about database unable to retrieve the data, this was an action=edit
Comment 7 Philippe Elie 2004-12-10 00:56:34 UTC
There is another way it can occur, this catched me sometime ago, slave was
lagging, I needed to revert some vandalism, going to history click on revision
alt-E alt-S but I didn't noticed the edit text was filled with the error message
about database unable to retrieve the data, this was an action=edit
Comment 8 Brion Vibber 2005-11-05 07:14:29 UTC
Currently does edit, not preview, but is still pulling in the new-page message text.
Comment 9 Rob Church 2006-12-03 12:52:42 UTC
Seems to have been fixed; something like
http://en.wikipedia.org/w/index.php?title=BugZilla_fun_for_all&action=submit now
spits out an "article doesn't exist" error, as one would expect.

[God help us if that ever turns into a bluelink.]
Comment 10 Rob Church 2006-12-03 13:38:35 UTC
Nope, on re-checking, it's still there; it's back to doing a preview and not
providing an edit form, etc.
Comment 11 Antoine "hashar" Musso (WMF) 2007-03-01 19:07:45 UTC
Works for me with trunk r20107
Comment 12 Chad H. 2008-12-13 20:09:49 UTC
And for me as of r44540. Closing, as it seems to have been fixed at some point.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links