Last modified: 2014-02-19 03:21:40 UTC
Should includes/templates/Userlogin.php be merged into the includes/SpecialUserlogin.php page, using the Xml.php methods to draw user-input fields, instead of the templating system, as per most of the other Special pages? For example, there is some overlap of form information between includes/SpecialPreferences.php's "User Profile" tab, and the login pages. However SpecialPreferences.php uses a single non-template file, and mostly outputs form fields using the Xml methods rather than outputting HTML directly, and overall seems nicer to work with because of it.
Looks like Gerrit change #27022 is related to this
The in-progress redesign of login/create account to use stacked labels and right-aligned help links[1] makes this more complicated. Even if we changed from undecorated list items to plain divs, HTMLForm and Xml would need changes to output the new CSS and layout. [1] https://www.mediawiki.org/wiki/Wikimedia_Foundation_Design/Login#Proposed
(In reply to comment #2) > The in-progress redesign of login/create account to use stacked labels and > right-aligned help links[1] makes this more complicated. Even if we changed > from undecorated list items to plain divs, HTMLForm and Xml would need > changes > to output the new CSS and layout. > > [1] https://www.mediawiki.org/wiki/Wikimedia_Foundation_Design/Login#Proposed Indeed, and I suggest that whatever team is doing the login page redesign look into what changes would need to be made, because it would be nonsensical to redesign the login page *before* resolving this issue. Otherwise we're just driving ourselves into a deeper hole.
This bug doesn't actually suggest to use HTMLForm (though I know that's the idea of https://gerrit.wikimedia.org/r/#/c/27022/).
(In reply to comment #4) > This bug doesn't actually suggest to use HTMLForm (though I know that's the > idea of https://gerrit.wikimedia.org/r/#/c/27022/). Indeed. My change just uses HTMLForm because it is the ideal case.
Change 27022 abandoned by Parent5446: Re-implemented Special:Userlogin using FormSpecialPage. Reason: The rest of the login system needs to be fixed before the UI part. https://gerrit.wikimedia.org/r/27022
Assuming Tyler isn't planning to continue working on this.
The discussion of https://www.mediawiki.org/wiki/Requests_for_comment/HTML_templating_library (including the in-person part at the summit, reflected at https://www.mediawiki.org/wiki/Architecture_Summit_2014/HTML_templating ) is relevant here.
