Last modified: 2004-12-05 02:56:35 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T2998, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 998 - OutputPage.php getHeadLinks() prevents meta tag content attribute values with double-quotes


Summary:	OutputPage.php getHeadLinks() prevents meta tag content attribute values with...

Status:	RESOLVED INVALID

Product:	MediaWiki
Classification:	Unclassified
Component:	Parser (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	Normal normal (vote)
Target Milestone:	---
Assigned To:	Nobody - You can work on this!

URL:
Whiteboard:
Keywords:	patch

Depends on:
Blocks:	982
	Show dependency tree / graph

Reported:	2004-12-04 12:27 UTC by Zigger
Modified:	2004-12-05 02:56 UTC (History)
CC List:	0 users

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Patch for REL1_3 (784 bytes, patch) 2004-12-04 12:30 UTC, Zigger	Details
Patch for HEAD & REL1_4 (772 bytes, patch) 2004-12-04 12:36 UTC, Zigger	Details
Add an attachment (proposed patch, testcase, etc.)

Description Zigger 2004-12-04 12:27:35 UTC

In OutputPage.php, getHeadLinks() generates meta tag content attribute values
wrapped in double-quotes, which breaks when the value contains double-quotes due
to extensions such as that attached to bug 982.

Patches to follow.

Comment 1 Zigger 2004-12-04 12:30:02 UTC

Created attachment 148 [details]
Patch for REL1_3

Comment 2 Zigger 2004-12-04 12:36:55 UTC

Created attachment 149 [details]
Patch for HEAD & REL1_4

Comment 3 Brion Vibber 2004-12-04 16:35:26 UTC

This patch doesn't make much sense. Instead, make sure you're appropriately escaping material (eg using 
htmlspecialchars()) so that double-quotes become &quot;

Comment 4 Zigger 2004-12-05 02:56:35 UTC

Thanks.  The patch seemed to make sense in regard to PICS meta tags, probably
due to the age of the specs, e.g.
http://www.w3c.org/TR/REC-PICS-labels#Embedding and a similar assertion at
http://www.icra.org/faq/professional/#elements

However, &quot; works with IE6-SP1 ok.  I'll update the bug 982 attachment in a
few hours.

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links