Last modified: 2004-12-05 02:56:35 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 998 - OutputPage.php getHeadLinks() prevents meta tag content attribute values with double-quotes
OutputPage.php getHeadLinks() prevents meta tag content attribute values with...
Product: MediaWiki
Classification: Unclassified
Parser (Other open bugs)
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
: patch
Depends on:
Blocks: 982
  Show dependency treegraph
Reported: 2004-12-04 12:27 UTC by Zigger
Modified: 2004-12-05 02:56 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Patch for REL1_3 (784 bytes, patch)
2004-12-04 12:30 UTC, Zigger
Patch for HEAD & REL1_4 (772 bytes, patch)
2004-12-04 12:36 UTC, Zigger

Description Zigger 2004-12-04 12:27:35 UTC
In OutputPage.php, getHeadLinks() generates meta tag content attribute values
wrapped in double-quotes, which breaks when the value contains double-quotes due
to extensions such as that attached to bug 982.

Patches to follow.
Comment 1 Zigger 2004-12-04 12:30:02 UTC
Created attachment 148 [details]
Patch for REL1_3
Comment 2 Zigger 2004-12-04 12:36:55 UTC
Created attachment 149 [details]
Patch for HEAD & REL1_4
Comment 3 Brion Vibber 2004-12-04 16:35:26 UTC
This patch doesn't make much sense. Instead, make sure you're appropriately escaping material (eg using 
htmlspecialchars()) so that double-quotes become "
Comment 4 Zigger 2004-12-05 02:56:35 UTC
Thanks.  The patch seemed to make sense in regard to PICS meta tags, probably
due to the age of the specs, e.g. and a similar assertion at

However, " works with IE6-SP1 ok.  I'll update the bug 982 attachment in a
few hours.

Note You need to log in before you can comment on or make changes to this bug.