Last modified: 2007-06-10 02:08:17 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 9166 - Recent changes rebuild script doesn't restore rc_bot value
Recent changes rebuild script doesn't restore rc_bot value
Product: MediaWiki
Classification: Unclassified
General/Unknown (Other open bugs)
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
: easy, patch, patch-need-review
Depends on:
  Show dependency treegraph
Reported: 2007-03-04 20:17 UTC by Gunter Schmidt
Modified: 2007-06-10 02:08 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

proposed patch for svn r20183 (454 bytes, patch)
2007-03-06 23:08 UTC, Makoto Imaizumi [Suisui]

Description Gunter Schmidt 2007-03-04 20:17:03 UTC
The script rebuildrecentchanges.php has a litte error. It does not check, if the user is a bot. Thus all 
changes by bots appear in the recent change list.

It should check if the user is a bot and set the bot-flag to 1.
Comment 1 Makoto Imaizumi [Suisui] 2007-03-06 23:08:51 UTC
Created attachment 3306 [details]
proposed patch for svn r20183

I made a patch for this trunk/ r20183
Comment 2 Rob Church 2007-03-06 23:22:27 UTC
Comments for Database::set() indicate it is deprecated. Use Database::update()
Comment 3 Makoto Imaizumi [Suisui] 2007-03-06 23:31:48 UTC
Database::update doesnt hang
ug_user=rc_user part cause Database::update uses makeList() to expand 
so it is treated as ug_user = 'rc_user'
Comment 4 end invites 2007-03-20 05:47:54 UTC
shouldn't this patch be reviewed?
Comment 5 Aaron Schulz 2007-06-03 22:38:31 UTC
Done in r22348.

Note You need to log in before you can comment on or make changes to this bug.