Last modified: 2007-06-10 02:08:17 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T11166, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 9166 - Recent changes rebuild script doesn't restore rc_bot value
Recent changes rebuild script doesn't restore rc_bot value
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
General/Unknown (Other open bugs)
1.11.x
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
: easy, patch, patch-need-review
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2007-03-04 20:17 UTC by Gunter Schmidt
Modified: 2007-06-10 02:08 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
proposed patch for svn r20183 (454 bytes, patch)
2007-03-06 23:08 UTC, Makoto Imaizumi [Suisui]
Details

Description Gunter Schmidt 2007-03-04 20:17:03 UTC
The script rebuildrecentchanges.php has a litte error. It does not check, if the user is a bot. Thus all 
changes by bots appear in the recent change list.

It should check if the user is a bot and set the bot-flag to 1.
Comment 1 Makoto Imaizumi [Suisui] 2007-03-06 23:08:51 UTC
Created attachment 3306 [details]
proposed patch for svn r20183

I made a patch for this trunk/ r20183
Comment 2 Rob Church 2007-03-06 23:22:27 UTC
Comments for Database::set() indicate it is deprecated. Use Database::update()
instead.
Comment 3 Makoto Imaizumi [Suisui] 2007-03-06 23:31:48 UTC
Database::update doesnt hang
ug_user=rc_user part cause Database::update uses makeList() to expand 
so it is treated as ug_user = 'rc_user'
Comment 4 end invites 2007-03-20 05:47:54 UTC
shouldn't this patch be reviewed?
Comment 5 Aaron Schulz 2007-06-03 22:38:31 UTC
Done in r22348.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links