Last modified: 2009-02-02 09:09:13 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 8996 - RTL in edit summary makes watchlist goes wild
RTL in edit summary makes watchlist goes wild
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Special pages (Other open bugs)
1.9.x
All All
: Normal major with 3 votes (vote)
: ---
Assigned To: Nobody - You can work on this!
: easy, patch, patch-need-review
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2007-02-15 19:12 UTC by Carl Fürstenberg
Modified: 2009-02-02 09:09 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
screenshot of the problem (641.98 KB, image/png)
2007-02-15 19:12 UTC, Carl Fürstenberg
Details
proposed patch just a line put into a div (723 bytes, patch)
2007-02-17 03:24 UTC, Makoto Imaizumi [Suisui]
Details

Description Carl Fürstenberg 2007-02-15 19:12:08 UTC
When one putted an RTL mark in edit summary, my watchlist has gone wild, and is
at the moment unusable, I will send a sacreenshot of the problem.
Comment 1 Carl Fürstenberg 2007-02-15 19:12:37 UTC
Created attachment 3228 [details]
screenshot of the problem
Comment 2 Jesse (Pathoschild) 2007-02-15 19:17:01 UTC
This could be fixed by somehow detecting and surrounding right-to-left text with
‏ and ‎ (see "Internationalization Best Practices: Handling
Right-to-left Scripts in XHTML and HTML Content",
http://www.w3.org/International/geo/html-tech/tech-bidi.html). The same fix
could be applied to in-line text, which causes similar problems on left-to-right
pages.
Comment 3 Brion Vibber 2007-02-15 19:50:42 UTC
The char that's mucking up here is a right-to-left override (U+202e).
This has effect to the end of the current paragraph in bidi layout.

Normally that would only be to the end of the current line in this sort of list
layout, but in enhanced recentchanges mode there's no block-level separation
between lines.

It might be possible to detect overrides and do a 'pop' or something appropriate
(more than the existing simple direction-poking chars), but a simple and
effective fix for the 'breaks the rest of the page' problem would probably be to
use <div>s appropriately in the enhanced RC layout.
Comment 4 Makoto Imaizumi [Suisui] 2007-02-17 03:24:44 UTC
Created attachment 3237 [details]
proposed patch just a line put into a div 

I've maked patch as Brion said,
just put a <div> and replace <br/> to </div>
need some CSS class??
Comment 5 Jesse (Pathoschild) 2007-02-17 09:00:57 UTC
*** Bug 9011 has been marked as a duplicate of this bug. ***
Comment 6 Carl Fürstenberg 2007-02-22 09:30:39 UTC
I'll change the severity to critical, as is a malicious user exploits this bug,
it might make it impossible for some to revert said edit.
Comment 7 Daniel Cannon (AmiDaniel) 2007-07-16 01:56:45 UTC
This seems to be fixed--though I'm not sure where or how it was fixed. In any case, on the experiments I've done on my testwikis have not presented this problem.
Comment 8 Brion Vibber 2007-07-18 01:12:50 UTC
Problem still present.

Note that it effects enhanced RC mode, not the plain mode. Add U+202e to a comment block to see. :D
Comment 9 Danny B. 2007-07-18 08:35:52 UTC
How about add &lrm; (&rlm; in RTL wikis) at the end of each comment parenthesis in the time of rendering?

So each comment will look like

(lorem ipsum emos idib txet&lrm;)

I made a JS script for myself which fixes enhanced RC this way and it works so I guess, it could be implemented on the server side.
Comment 10 Ral315 2008-03-01 19:57:35 UTC
Any fixes for this should probably fix not only this bug, but the general RTL problem that occurs whenever a right-to-left script ends an edit summary (the next line's javascript arrow is unusable)  See bug 7885 for details.
Comment 11 Siebrand Mazeland 2009-02-02 09:09:13 UTC
Closed as fixed per bug 7885.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links