Last modified: 2009-02-02 09:09:13 UTC
When one putted an RTL mark in edit summary, my watchlist has gone wild, and is at the moment unusable, I will send a sacreenshot of the problem.
Created attachment 3228 [details] screenshot of the problem
This could be fixed by somehow detecting and surrounding right-to-left text with ‏ and ‎ (see "Internationalization Best Practices: Handling Right-to-left Scripts in XHTML and HTML Content", http://www.w3.org/International/geo/html-tech/tech-bidi.html). The same fix could be applied to in-line text, which causes similar problems on left-to-right pages.
The char that's mucking up here is a right-to-left override (U+202e). This has effect to the end of the current paragraph in bidi layout. Normally that would only be to the end of the current line in this sort of list layout, but in enhanced recentchanges mode there's no block-level separation between lines. It might be possible to detect overrides and do a 'pop' or something appropriate (more than the existing simple direction-poking chars), but a simple and effective fix for the 'breaks the rest of the page' problem would probably be to use <div>s appropriately in the enhanced RC layout.
Created attachment 3237 [details] proposed patch just a line put into a div I've maked patch as Brion said, just put a <div> and replace <br/> to </div> need some CSS class??
*** Bug 9011 has been marked as a duplicate of this bug. ***
I'll change the severity to critical, as is a malicious user exploits this bug, it might make it impossible for some to revert said edit.
This seems to be fixed--though I'm not sure where or how it was fixed. In any case, on the experiments I've done on my testwikis have not presented this problem.
Problem still present. Note that it effects enhanced RC mode, not the plain mode. Add U+202e to a comment block to see. :D
How about add ‎ (‏ in RTL wikis) at the end of each comment parenthesis in the time of rendering? So each comment will look like (lorem ipsum emos idib txet‎) I made a JS script for myself which fixes enhanced RC this way and it works so I guess, it could be implemented on the server side.
Any fixes for this should probably fix not only this bug, but the general RTL problem that occurs whenever a right-to-left script ends an edit summary (the next line's javascript arrow is unusable) See bug 7885 for details.
Closed as fixed per bug 7885.
