Last modified: 2013-12-24 07:53:38 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 8821 - When using another language, messages of "-" that are not exist in the DB are shown as "<message>"
When using another language, messages of "-" that are not exist in the DB are...
Status: RESOLVED WORKSFORME
Product: MediaWiki
Classification: Unclassified
Internationalization (Other open bugs)
unspecified
All All
: Low trivial (vote)
: ---
Assigned To: Nobody - You can work on this!
: i18n, patch, patch-reviewed, testme
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2007-01-29 13:48 UTC by Kkkdc @jawiki
Modified: 2013-12-24 07:53 UTC (History)
13 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
patch for r19687 (594 bytes, patch)
2007-01-30 08:59 UTC, Kkkdc @jawiki
Details

Description Kkkdc @jawiki 2007-01-29 13:48:35 UTC
When using 'uselang=xx' or setting user language,
'<shareddescriptionfollows>' appears in ImagePage.

It's too ugly.
Comment 1 Rotem Liss 2007-01-29 15:01:19 UTC
The problem seems to be caused by the fix of Bug 6126 (r14493), combined with
the recent deletion of most system messages: when a message contains just "-"
(like "shareddescriptionfollows" by default) is used, the user language is not
the content language and the DB is used, MessageCache::getMsgFromNamespace is
used regardless the existance of the message in the DB (and it *was* exist and
equal to "-" before the deletion of system messages, so the bug was hidden).
Thus, "-" is overriden by "<shareddescriptionfollows>".

I think that a fix for this bug should get the result of
MessageCache::getMsgFromNamespace to a temporary variable, and check if it's an
empty message before assigning it to $message.
Comment 2 Rob Church 2007-01-29 17:45:24 UTC
We should probably also ship some default message text, e.g. "this image is from
a shared repository" or similar.
Comment 3 Rotem Liss 2007-01-29 17:48:43 UTC
(In reply to comment #2)
> We should probably also ship some default message text, e.g. "this image is from
> a shared repository" or similar.

I think it's already exist in the message "sharedupload".
Comment 4 Kkkdc @jawiki 2007-01-30 08:59:20 UTC
Created attachment 3159 [details]
patch for r19687
Comment 5 Kkkdc @jawiki 2007-01-30 09:05:15 UTC
(In reply to comment #1)

You say, like attachment 3159 [details]?
I see, It works fine in this case.
Comment 6 Rotem Liss 2007-03-18 15:48:50 UTC
This specific problem should be fixed in r20550. I'm not closing this bug,
though, as it's a general problem which is not specific to
"shareddescriptionfollows". Changing the summary to reflect it. See Comment 1
for a detailed explanation of this bug.
Comment 7 p858snake 2011-04-30 00:09:55 UTC
*Bulk BZ Change: +Patch to open bugs with patches attached that are missing the keyword*
Comment 8 au 2012-06-17 17:44:46 UTC
Hi Kkkdc, thank you for the patch!

As you may already know, MediaWiki is currently revamping its PHP-based parser
into a "Parsoid" prototype component, to support the rich-text Visual Editor
project:

   https://www.mediawiki.org/wiki/Parsoid
   https://www.mediawiki.org/wiki/Visual_editor

Folks interested in enhancing the parser's capabilities are very much welcome
to join the Parsoid project, and contribute patches as Git branches:

   https://www.mediawiki.org/wiki/Git/Tutorial#How_to_submit_a_patch

Compared to .diff attachments in Bugzilla tickets, Git branches are much easier
for us to review, refine and merge features together.

Each change set has a distinct URL generated by the "git review" tool, which
can be referenced in Bugzilla by pasting its gerrit.wikimedia.org URL as a
comment.

If you run into any issues with the patch process, please feel free to ask on
irc.freenode.net #wikimedia-dev and the wikitext-l mailing list. Thank you!
Comment 9 Nemo 2012-07-25 07:56:45 UTC
Isn't this yet another fallback language bug to be moved to Internationalization component?
Comment 10 Vishnu Nk 2013-12-24 04:58:51 UTC
I found the MessageCache.php file in /includes/cache folder.
But i couldn't find the desired codes in those lines mentioned above.
Can you please make sure about the file path and the line number please?
Comment 11 Bawolff (Brian Wolff) 2013-12-24 05:35:16 UTC
Re patch review:
No longer applies, too old.

(In reply to comment #9)
> Isn't this yet another fallback language bug to be moved to
> Internationalization component?

Indeed it should be in i18n component

----

However, I can't reproduce this bug. Perhaps I misunderstand it? Is this bug still present?
Comment 12 Bawolff (Brian Wolff) 2013-12-24 05:58:25 UTC
yeah, definitely cannot reproduce. Closing WORKSFORME. Please repoen if still present.
Comment 13 Nemo 2013-12-24 07:53:38 UTC
(In reply to comment #12)
> yeah, definitely cannot reproduce. Closing WORKSFORME. Please repoen if still
> present.

Might have been solved by bug 1495 and/or bug 14176.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links