Last modified: 2006-12-22 02:36:45 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 8247 - minor cleanup of CoreParserFunctions.php
minor cleanup of CoreParserFunctions.php
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Parser (Other open bugs)
1.9.x
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
: patch-reviewed
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2006-12-13 14:39 UTC by Carl Fürstenberg
Modified: 2006-12-22 02:36 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
the patch (1.06 KB, patch)
2006-12-13 14:39 UTC, Carl Fürstenberg
Details
the patch with parserTest (1.41 KB, patch)
2006-12-13 23:47 UTC, Carl Fürstenberg
Details
updated urlFunctions (2.92 KB, patch)
2006-12-14 19:22 UTC, Carl Fürstenberg
Details

Description Carl Fürstenberg 2006-12-13 14:39:08 UTC
see attached patch
Comment 1 Carl Fürstenberg 2006-12-13 14:39:42 UTC
Created attachment 2856 [details]
the patch

some minor cleanup of the code.
Comment 2 Carl Fürstenberg 2006-12-13 23:47:19 UTC
Created attachment 2861 [details]
the patch with parserTest

added the parsertest for anchorencode
Comment 3 Carl Fürstenberg 2006-12-14 19:22:58 UTC
Created attachment 2864 [details]
updated urlFunctions

added funtionallity that in my brain was logical, as the posibillity to build
query string by concatenate all extra parameters, for example
{{localurl:Foo|a=1|b=2|c=3}} to give 
index.php?title=Foo&bar=baz&baz&boo
/~azatoth/srcwiki/index.php?title=Foo&a=1&b=2&c=3
Comment 4 Carl Fürstenberg 2006-12-14 19:23:46 UTC
(In reply to comment #3)
> Created an attachment (id=2864) [edit]
> updated urlFunctions
> 
> added funtionallity that in my brain was logical, as the posibillity to build
> query string by concatenate all extra parameters, for example
> {{localurl:Foo|a=1|b=2|c=3}} to give 
> index.php?title=Foo&bar=baz&baz&boo
> /~azatoth/srcwiki/index.php?title=Foo&a=1&b=2&c=3

ment only "index.php?title=Foo&a=1&b=2&c=3", manage to copy a row too much
Comment 5 Rob Church 2006-12-14 21:05:35 UTC
Please don't add major new functions in a patch that's supposed to be a "minor
cleanup" - the two MUST be kept separate for code review reasons.

(Word of advice: The phrase "in my brain, [it] was logical" ALWAYS backfires on
you...)
Comment 6 Carl Fürstenberg 2006-12-14 21:34:24 UTC
(In reply to comment #5)
> Please don't add major new functions in a patch that's supposed to be a "minor
> cleanup" - the two MUST be kept separate for code review reasons.
> 
> (Word of advice: The phrase "in my brain, [it] was logical" ALWAYS backfires on
> you...)

oh, sorry, perhaps you are right, sorry for making you upset, I'll revert it
Comment 7 Carl Fürstenberg 2006-12-22 01:19:50 UTC
Would like this to be committed if possible, it's rather straightforward I think
Comment 8 Rob Church 2006-12-22 02:36:45 UTC
Applied on r18484. Patience is a virtue.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links