Last modified: 2008-01-20 18:53:54 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T10000, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 8000 - Move @access public/private/protected qualifiers to PHP 5 keywords
Move @access public/private/protected qualifiers to PHP 5 keywords
Status: RESOLVED DUPLICATE of bug 5176
Product: MediaWiki
Classification: Unclassified
General/Unknown (Other open bugs)
1.9.x
All All
: Normal enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2006-11-20 22:49 UTC by Carl Fürstenberg
Modified: 2008-01-20 18:53 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
the breaking patch (2.18 KB, patch)
2006-11-20 22:49 UTC, Carl Fürstenberg 		Details
Add an attachment (proposed patch, testcase, etc.)

Description Carl Fürstenberg 2006-11-20 22:49:33 UTC 
QuickTemplate in SkinTemplate.php defines a couple of functions as ment to be
private, following pathc will activate this behaviour, but will thou break at
least monobook.
Comment 1 Carl Fürstenberg 2006-11-20 22:49:55 UTC 
Created attachment 2750 [details]
the breaking patch
Comment 2 Aryeh Gregor (not reading bugmail, please e-mail directly) 2006-11-21 03:42:39 UTC 
There are lots of things marked @private and @public from when MW was PHP 4, and
all should have the labels transferred to the PHP 5 keyword.  In the case of
private/protected, this should only be done if you're really sure that nothing
else anywhere uses the method.  "Will break Monobook" isn't remotely acceptable.

Did I understand your problem with this bug correctly?  Comment #0 is hard to
understand.
Comment 3 Rob Church 2006-11-21 03:47:04 UTC 

*** This bug has been marked as a duplicate of 5176 ***
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links