Last modified: 2014-11-12 14:55:12 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T74666, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 72666 - Unify view-implementations in JS frontend
Unify view-implementations in JS frontend
Status: NEW
Product: MediaWiki extensions
Classification: Unclassified
WikidataRepo (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Wikidata bugs
u=dev c=frontend p=13
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-10-29 09:16 UTC by tobias.gritschacher
Modified: 2014-11-12 14:55 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description tobias.gritschacher 2014-10-29 09:16:53 UTC

    
Comment 1 Henning 2014-11-11 08:57:52 UTC
https://gerrit.wikimedia.org/r/#/c/172507/
Comment 2 Adrian Lang 2014-11-11 09:22:54 UTC
From my point of view, steps could be:

* Make a list of interfaces and behaviours our widgets possess
* Extract common interfaces (might not be code interfaces, since JS is not particularly good with them)
* Unify implementations, document which widget implements which interface

I'd strongly prefer to not increase code reusage through inheritance.
Comment 3 Adrian Lang 2014-11-11 09:29:14 UTC
Despite the last sentence in my previous comment I still think Henning's patch is an improvement and could be merged :)
Comment 4 Adrian Lang 2014-11-12 14:55:12 UTC
Another step I forgot: Write tests for all interfaces, run the tests against the widgets implementing an interface.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links