Last modified: 2014-11-05 14:41:04 UTC
In snakview.variations.Value.draw(), jQuery.valueview's startEditing() or stopEditing() function is called according to whether the ViewState is in edit mode. stopEditing() is always called without a parameter although the dropValue parameter should be specified when editing has been canceled (in contrast to saving). This may not be an urgent problem since the valueview is probably destroyed after canceling anyway. However, this abuse hints wrong code architecture and may cause false assumptions and trigger errors in the future.
https://gerrit.wikimedia.org/r/#/c/170038/
Change 170038 had a related patch set uploaded by Tobias Gritschacher: Added snakview.variations.Value.start/stopEditing() https://gerrit.wikimedia.org/r/170038
Change 170038 merged by jenkins-bot: Added snakview.variations.Value.start/stopEditing() https://gerrit.wikimedia.org/r/170038