Last modified: 2006-09-01 11:33:49 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T9188, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 7188 - HTMLForm.php Bug - $this->mName used twice in a row


Summary:	HTMLForm.php Bug - $this->mName used twice in a row

Status:	RESOLVED FIXED

Product:	MediaWiki
Classification:	Unclassified
Component:	Interface (Other open bugs)
Version:	1.8.x
Hardware:	All All

Importance:	Normal normal (vote)
Target Milestone:	---
Assigned To:	Nobody - You can work on this!

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2006-09-01 05:53 UTC by Eric Johnston
Modified:	2006-09-01 11:33 UTC (History)
CC List:	0 users

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Patch for HTMLForm.php (448 bytes, patch) 2006-09-01 08:35 UTC, Eric Johnston	Details
Add an attachment (proposed patch, testcase, etc.)

Description Eric Johnston 2006-09-01 05:53:10 UTC

In the radiobox() function $this->mName and the dash should be removed from the
call to fieldset().

Here's the patch:

Index: includes/HTMLForm.php
===================================================================
--- includes/HTMLForm.php       (revision 16313)
+++ includes/HTMLForm.php       (working copy)
@@ -71,7 +71,7 @@
                                ( $checked ? ' checked="checked"' : '' ) . " />"
. wfMsg( $this->mName.'-'.$varname.'-'.$value ) .
                                "</label></div>\n";
                }
-               return $this->fieldset( $this->mName.'-'.$varname, $s );
+               return $this->fieldset( $varname, $s );
        }

        /**

Comment 1 Eric Johnston 2006-09-01 08:35:57 UTC

Created attachment 2289 [details]
Patch for HTMLForm.php

Comment 2 Brion Vibber 2006-09-01 10:12:26 UTC

For what reason?

Comment 3 Eric Johnston 2006-09-01 10:19:57 UTC

Look in fieldset() - it's prepending $this->mName twice.  Once in this method
(radiobox()) when it calls fieldset() and once in the fieldset() method itself.
 You end up with $this->mName . '-' . $this->mName . '-' . $varname, which
doesn't make sense.

Comment 4 Brion Vibber 2006-09-01 11:33:49 UTC

Committed on r16320.

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links