Last modified: 2006-09-01 11:33:49 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 7188 - HTMLForm.php Bug - $this->mName used twice in a row
HTMLForm.php Bug - $this->mName used twice in a row
Product: MediaWiki
Classification: Unclassified
Interface (Other open bugs)
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
Depends on:
  Show dependency treegraph
Reported: 2006-09-01 05:53 UTC by Eric Johnston
Modified: 2006-09-01 11:33 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Patch for HTMLForm.php (448 bytes, patch)
2006-09-01 08:35 UTC, Eric Johnston

Description Eric Johnston 2006-09-01 05:53:10 UTC
In the radiobox() function $this->mName and the dash should be removed from the
call to fieldset().

Here's the patch:

Index: includes/HTMLForm.php
--- includes/HTMLForm.php       (revision 16313)
+++ includes/HTMLForm.php       (working copy)
@@ -71,7 +71,7 @@
                                ( $checked ? ' checked="checked"' : '' ) . " />"
. wfMsg( $this->mName.'-'.$varname.'-'.$value ) .
-               return $this->fieldset( $this->mName.'-'.$varname, $s );
+               return $this->fieldset( $varname, $s );

Comment 1 Eric Johnston 2006-09-01 08:35:57 UTC
Created attachment 2289 [details]
Patch for HTMLForm.php
Comment 2 Brion Vibber 2006-09-01 10:12:26 UTC
For what reason?
Comment 3 Eric Johnston 2006-09-01 10:19:57 UTC
Look in fieldset() - it's prepending $this->mName twice.  Once in this method
(radiobox()) when it calls fieldset() and once in the fieldset() method itself.
 You end up with $this->mName . '-' . $this->mName . '-' . $varname, which
doesn't make sense.
Comment 4 Brion Vibber 2006-09-01 11:33:49 UTC
Committed on r16320.

Note You need to log in before you can comment on or make changes to this bug.