Last modified: 2014-07-14 10:17:18 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T69938, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 67938 - Block::newFromTarget gets autoblocks when its documentation says it doesn't
Block::newFromTarget gets autoblocks when its documentation says it doesn't
Status: NEW
Product: MediaWiki
Classification: Unclassified
User blocking (Other open bugs)
All All
: Normal major (vote)
: ---
Assigned To: Nobody - You can work on this!
Depends on:
Blocks: documentation
  Show dependency treegraph
Reported: 2014-07-13 03:53 UTC by Jackmcbarn
Modified: 2014-07-14 10:17 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Description Jackmcbarn 2014-07-13 03:53:18 UTC
Block::newFromTarget returns autoblocks when its second parameter is null, even though its doc comment specifically says that it won't. This is dangerous because callers that believe the doc comment could end up leaking autoblocks. I'm not sure whether it's the code or the comment that's "right", though. See comments on I9ea77ae1ac31b44f2bb9767d41192dc0ae492c28

Note You need to log in before you can comment on or make changes to this bug.