Last modified: 2014-08-06 13:54:30 UTC
An EducationProgram unit test fails with the rather unobvious error: EducationProgram\Tests\ActionsTest::testSpecial with data set #1 ('edit', EducationProgram\CoursePage) PermissionsError: includes/actions/Action.php:292 includes/actions/FormlessAction.php:65 extensions/EducationProgram/tests/phpunit/ActionsTest.php:63 tests/phpunit/MediaWikiTestCase.php:133 tests/phpunit/MediaWikiPHPUnitCommand.php:42 tests/phpunit/phpunit.php:160 https://integration.wikimedia.org/ci/job/mediawiki-core-extensions-integration/67/testReport/(root)/EducationProgram_Tests_ActionsTest__testSpecial/testSpecial_with_data_set__1/
Looks like the actions test tries the 'edit' action, but it runs against the abstract class \EducationPage and all the actions (including 'edit') are specified in the two implementations, \CoursePage and \OrgPage.
Err. Nevermind about the above. It might have something to do with the recent changes to course page edit rights, which went from having a single 'edit' restriction to a two-tier permission where any user can do basic edits, but only users with advanced rights have access to all the editable fields on a course page. But looking over the code for that, I can't see what is causing the test to fail.
It's failing due to WikimediaIncubator which adds its own permission checks. Is seems to be a rather architectural problem which I can't fix myself, especially since WI has no tests.
Changed title to something less pretentious.
(In reply to Max Semenik from comment #3) > It's failing due to WikimediaIncubator which adds its own permission checks. > Is seems to be a rather architectural problem which I can't fix myself, > especially since WI has no tests. Since it is of the main aspects of the WikimediaIncubator extension to add extra permission checks, it seems to me that this bug needs a fix in the EducationProgram, not in WI (though I haven't looked at the EP code). And WI does have tests, though not many. I don't know how EducationProgram works, but I think extensions like that one will be quite difficult to work in Incubator anyway.
See also Bug 67615 - PageTriage: test SpecialNewPagesFeedTest::testAddArticles has 'Unknown error: "wminc-error-unprefixed"
