Last modified: 2010-05-15 15:56:54 UTC
Feature in function GlobalFunctions::wfReadOnly(), commented, "Set $wgReadOnly
for faster access next time" causes test GlobalTest::testReadOnlySet() to fail.
1. $wgReadOnly starts as null
2. GlobalTest::testReadOnlyEmpty() calls wfReadOnly(). Since $wgReadOnly is
null, $wgReadOnlyFile is read, and, assuming it's empty, $wgReadOnly is set to
3. GlobalTest::testReadOnlySet() modifies the file described by $wgReadOnlyFile
and calls wfReadOnly(), which does not open the file again but instead returns
the value of $wgReadOnly ("false").
Created attachment 2042 [details]
patch for GlobalTest.php
patch for GlobalTest.php that resets $wgReadOnly to null before each call to
wfReadOnly(), which forces wfReadOnly() to read "read only" status from file.
This *should* have been fixed in r22801...
Going to consider this fixed per comment 2.