Last modified: 2010-05-15 15:56:54 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 6522 - GlobalTest::testReadOnlySet() fails due to feature in GlobalFunctions::wfReadOnly()
GlobalTest::testReadOnlySet() fails due to feature in GlobalFunctions::wfRead...
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
General/Unknown (Other open bugs)
1.6.x
PC All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
: testme
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2006-07-03 04:18 UTC by x1
Modified: 2010-05-15 15:56 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
patch for GlobalTest.php (764 bytes, patch)
2006-07-03 04:27 UTC, x1
Details

Description x1 2006-07-03 04:18:26 UTC
Feature in function GlobalFunctions::wfReadOnly(), commented, "Set $wgReadOnly
for faster access next time" causes test GlobalTest::testReadOnlySet() to fail.

1. $wgReadOnly starts as null
2. GlobalTest::testReadOnlyEmpty() calls wfReadOnly(). Since $wgReadOnly is
null, $wgReadOnlyFile is read, and, assuming it's empty, $wgReadOnly is set to
"false"
3. GlobalTest::testReadOnlySet() modifies the file described by $wgReadOnlyFile
and calls wfReadOnly(), which does not open the file again but instead returns
the value of $wgReadOnly ("false").
Comment 1 x1 2006-07-03 04:27:06 UTC
Created attachment 2042 [details]
patch for GlobalTest.php

patch for GlobalTest.php that resets $wgReadOnly to null before each call to
wfReadOnly(), which forces wfReadOnly() to read "read only" status from file.
Comment 2 Rob Church 2007-06-08 00:42:11 UTC
This *should* have been fixed in r22801...
Comment 3 Siebrand Mazeland 2008-08-16 19:18:27 UTC
Going to consider this fixed per comment 2.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links