Last modified: 2010-05-15 15:56:54 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T8522, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 6522 - GlobalTest::testReadOnlySet() fails due to feature in GlobalFunctions::wfReadOnly()
GlobalTest::testReadOnlySet() fails due to feature in GlobalFunctions::wfRead...
Product: MediaWiki
Classification: Unclassified
General/Unknown (Other open bugs)
PC All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
: testme
Depends on:
  Show dependency treegraph
Reported: 2006-07-03 04:18 UTC by x1
Modified: 2010-05-15 15:56 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

patch for GlobalTest.php (764 bytes, patch)
2006-07-03 04:27 UTC, x1

Description x1 2006-07-03 04:18:26 UTC
Feature in function GlobalFunctions::wfReadOnly(), commented, "Set $wgReadOnly
for faster access next time" causes test GlobalTest::testReadOnlySet() to fail.

1. $wgReadOnly starts as null
2. GlobalTest::testReadOnlyEmpty() calls wfReadOnly(). Since $wgReadOnly is
null, $wgReadOnlyFile is read, and, assuming it's empty, $wgReadOnly is set to
3. GlobalTest::testReadOnlySet() modifies the file described by $wgReadOnlyFile
and calls wfReadOnly(), which does not open the file again but instead returns
the value of $wgReadOnly ("false").
Comment 1 x1 2006-07-03 04:27:06 UTC
Created attachment 2042 [details]
patch for GlobalTest.php

patch for GlobalTest.php that resets $wgReadOnly to null before each call to
wfReadOnly(), which forces wfReadOnly() to read "read only" status from file.
Comment 2 Rob Church 2007-06-08 00:42:11 UTC
This *should* have been fixed in r22801...
Comment 3 Siebrand Mazeland 2008-08-16 19:18:27 UTC
Going to consider this fixed per comment 2.

Note You need to log in before you can comment on or make changes to this bug.