Last modified: 2014-05-29 20:27:35 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T64306, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 62306 - Need error message and/or better design for thumbnails broken due to megapixel limit
Need error message and/or better design for thumbnails broken due to megapixe...
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
PagedTiffHandler (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
: i18n
Depends on:
Blocks: messages tiff-handling
  Show dependency treegraph
 
Reported: 2014-03-06 06:33 UTC by Dominic
Modified: 2014-05-29 20:27 UTC (History)
8 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Dominic 2014-03-06 06:33:14 UTC
https://commons.wikimedia.org/wiki/File:Constitution_of_the_United_States,_page_1.tif is a high-resolution TIFF file which is above the current megapixel limit for rendering thumbnails.

As a result, image description pages just render a large broken thumbnail image, but do not communicate to the user what the problem is. In particular, since this is how the image will always render due to its large resolution, not a temporary issue, the design could be improved so it is not so confusing to the user (and so it is clearer that they can download the original file if desired).
Comment 1 Bawolff (Brian Wolff) 2014-03-06 07:39:14 UTC
PagedTiffHandler checks size limits at wrong stage (not that mw default behaviour is any better)
Comment 2 Gerrit Notification Bot 2014-05-23 20:10:22 UTC
Change 135101 had a related patch set uploaded by Brian Wolff:
Check $wgMaxImageArea before downloading file asset from swift

https://gerrit.wikimedia.org/r/135101
Comment 3 Bawolff (Brian Wolff) 2014-05-23 20:16:37 UTC
(In reply to Gerrit Notification Bot from comment #2)
> Change 135101 had a related patch set uploaded by Brian Wolff:
> Check $wgMaxImageArea before downloading file asset from swift
> 
> https://gerrit.wikimedia.org/r/135101

This will make the error message be the same as other files get (e.g. GIFs) namely: https://commons.wikimedia.org/wiki/MediaWiki:Thumbnail_invalid_params


I think we need a less hacky system for dealing with megapixel limit. See bug 32387 for that issue.
Comment 4 Gerrit Notification Bot 2014-05-29 08:35:45 UTC
Change 135101 merged by jenkins-bot:
Check $wgMaxImageArea before downloading file asset from swift

https://gerrit.wikimedia.org/r/135101
Comment 5 Bawolff (Brian Wolff) 2014-05-29 08:45:17 UTC
Calling this fixed as there now actually is an error (look for it on commons on tuesday). For general better error handling of this situation  see bug 32387
Comment 6 Dominic 2014-05-29 20:27:35 UTC
(In reply to Bawolff (Brian Wolff) from comment #5)
> Calling this fixed as there now actually is an error (look for it on commons
> on tuesday). For general better error handling of this situation  see bug
> 32387

Would this fix bug 65552 as well?

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links