Last modified: 2014-05-29 20:27:35 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
First Last Prev Next    This bug is not in your last search results.
Bug 62306 - Need error message and/or better design for thumbnails broken due to megapixel limit
Need error message and/or better design for thumbnails broken due to megapixe...
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
PagedTiffHandler (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
: i18n
Depends on:
Blocks: messages tiff-handling
  Show dependency tree / graph
 
Reported: 2014-03-06 06:33 UTC by Dominic
Modified: 2014-05-29 20:27 UTC (History)
8 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Dominic 2014-03-06 06:33:14 UTC 
https://commons.wikimedia.org/wiki/File:Constitution_of_the_United_States,_page_1.tif is a high-resolution TIFF file which is above the current megapixel limit for rendering thumbnails.

As a result, image description pages just render a large broken thumbnail image, but do not communicate to the user what the problem is. In particular, since this is how the image will always render due to its large resolution, not a temporary issue, the design could be improved so it is not so confusing to the user (and so it is clearer that they can download the original file if desired).
Comment 1 Bawolff (Brian Wolff) 2014-03-06 07:39:14 UTC 
PagedTiffHandler checks size limits at wrong stage (not that mw default behaviour is any better)
Comment 2 Gerrit Notification Bot 2014-05-23 20:10:22 UTC 
Change 135101 had a related patch set uploaded by Brian Wolff:
Check $wgMaxImageArea before downloading file asset from swift

https://gerrit.wikimedia.org/r/135101
Comment 3 Bawolff (Brian Wolff) 2014-05-23 20:16:37 UTC 
(In reply to Gerrit Notification Bot from comment #2)
> Change 135101 had a related patch set uploaded by Brian Wolff:
> Check $wgMaxImageArea before downloading file asset from swift
> 
> https://gerrit.wikimedia.org/r/135101

This will make the error message be the same as other files get (e.g. GIFs) namely: https://commons.wikimedia.org/wiki/MediaWiki:Thumbnail_invalid_params


I think we need a less hacky system for dealing with megapixel limit. See bug 32387 for that issue.
Comment 4 Gerrit Notification Bot 2014-05-29 08:35:45 UTC 
Change 135101 merged by jenkins-bot:
Check $wgMaxImageArea before downloading file asset from swift

https://gerrit.wikimedia.org/r/135101
Comment 5 Bawolff (Brian Wolff) 2014-05-29 08:45:17 UTC 
Calling this fixed as there now actually is an error (look for it on commons on tuesday). For general better error handling of this situation  see bug 32387
Comment 6 Dominic 2014-05-29 20:27:35 UTC 
(In reply to Bawolff (Brian Wolff) from comment #5)
> Calling this fixed as there now actually is an error (look for it on commons
> on tuesday). For general better error handling of this situation  see bug
> 32387

Would this fix bug 65552 as well?
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links