Last modified: 2014-05-03 00:19:10 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T62017, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 60017 - Flow: Reference numbers in Parsoid output aren't superscripted
Flow: Reference numbers in Parsoid output aren't superscripted
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
Flow (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on: 51245
Blocks:
  Show dependency treegraph
 
Reported: 2014-01-13 21:58 UTC by Quiddity
Modified: 2014-05-03 00:19 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Comment 1 Bingle 2014-01-13 22:01:18 UTC
The WMF core features team tracks this bug on Mingle card https://wikimedia.mingle.thoughtworks.com/projects/flow/cards/720, but people from the community are welcome to contribute here and in Gerrit.
Comment 2 Quiddity 2014-01-13 22:17:57 UTC
Also, in the mediawikiwiki example (https://www.mediawiki.org/w/index.php?title=Talk:Sandbox&workflow=050e2fb772abdae40bd7842b2b77d26b#flow-post-050e2fc7a956d409439790b11c278af6 ) there is also a problem with the {{reflist}} being in a <pre> formatted div.  

/Possibly/ this has the same root problem?  I notice in the html-source code that there are a lot of &quot;s (or &amp;quot;s if the first gets converted in this comment).

Or possibly it's because the [[mw:Template:Reflist]] is much older than the [[Template:Reflist]] at Enwiki and ee-flow?

I'm not sure if I should open a separate bug for that...?
Comment 3 spage 2014-03-15 07:28:33 UTC
The pre-formatted div you mention in #comment 2 seems fixed on mediawiki.

The lack of superscript may be because Parsoid doesn't run the <ref> tag through Extension:Cite/Cite.php – it doesn't use the PHP parser's hooks. But it clearly does something with the <ref> tag, turning it into a <span class="reference"> containing a hyperlink with a counted element.  If it's by design that Parsoid doesn't output a <sup> tag, then a workaround could be to include Parsoid-specific CSS matching the browser's built-in styling of <sup> i.e.

  span.reference { font-size: smaller; line-height: normal; vertical-align: super;}

Some other glitches with reference tags:

* The hyperlinks between the citation [1] and the reference are #citeANCHORNAME fragments, but because the Flow page includes a <base href="/wiki/Talk:Sandbox"> (in order to make relative links work?), following the links when you're viewing this topic in isolation makes you leave the current page, and if it's scrolled off the Flow board the link won't work. This happens on http://parsoid.wmflabs.org/_wikitext/ , I'll file a separate bug.

* Each post restarts its citation counters. It's technically illegal HTML to have two id="cite_note-1" in one document and it's undefined what hyperlinks using that as a fragment will do. So citations can never work correctly when the Flow board or single topic view shows more than one post using them, unless each Flow post provides an anchorPrefixParameter to Parsoid like '#flow-postId-flow-post-rn84j0djfcyxetu8-' , and Parsoid prepends that when generating id, name, and href attributes. Another separate bug.
Comment 4 spage 2014-03-15 08:21:49 UTC
(In reply to spage from comment #3)

> * The hyperlinks between the citation [1] and the reference are
> #citeANCHORNAME fragments, but because the Flow page includes a
> <base href="/wiki/Talk:Sandbox"> ... [they] won't work.

I filed bug 62691, maybe Flow doesn't need to output <base href> any more.
Comment 5 Gerrit Notification Bot 2014-04-09 01:57:43 UTC
Change 124787 had a related patch set uploaded by Spage:
Add Parsoid's CSS modules

https://gerrit.wikimedia.org/r/124787
Comment 6 Gerrit Notification Bot 2014-04-29 19:17:32 UTC
Change 124787 merged by jenkins-bot:
Add Parsoid's CSS modules

https://gerrit.wikimedia.org/r/124787
Comment 7 spage 2014-05-03 00:15:18 UTC
The superscripting is fixed in 1.24wmf3, the other glitches in comment #3, should probably be filed as enhancements.
Comment 8 Gabriel Wicke 2014-05-03 00:19:10 UTC
Also relevant: https://gerrit.wikimedia.org/r/#/c/130770/

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links