Last modified: 2014-09-24 01:23:40 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T7004, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 5004 - Keep the pipe trick ([[Piped link|]]) syntax in wikitext instead of converting it at pre-save transform
Keep the pipe trick ([[Piped link|]]) syntax in wikitext instead of convertin...
Product: MediaWiki
Classification: Unclassified
Page editing (Other open bugs)
All All
: Low normal with 2 votes (vote)
: ---
Assigned To: Nobody - You can work on this!
: newparser, patch, patch-reviewed
Depends on:
  Show dependency treegraph
Reported: 2006-02-16 00:00 UTC by Chris Wood
Modified: 2014-09-24 01:23 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

A patch to fix this (660 bytes, patch)
2010-02-09 19:15 UTC, Conrad Irwin

Description Chris Wood 2006-02-16 00:00:49 UTC
We should keep the [[w:pipe trick|]] as it is entered instead of converting it to [[w:pipe 
trick|pipe trick]]. The pipe trick is clearer, easier to read, takes less space, and demonstrates 
to newer users that it is possible.
Comment 1 Helder 2009-09-17 17:04:17 UTC
As was pointed above by Chris Wood, and at wikitech [1] by Aryeh Gregor, this trick should be part of the saved wikitext, not pre-converted on saving the page.

[1] -
Comment 2 Conrad Irwin 2010-02-09 19:15:35 UTC
Created attachment 7093 [details]
A patch to fix this

I am not comfortable with fixing this myself, it seems like a very drastic change for very little benefit (particularly now the pipe trick works during normal parsing too). 

While the usabiltiy concern that it might be less easy to read the wikitext if the pipe trick is left, was countered by the argument that then people would find out about the pipe trick sooner, and thus increase productivity.

The other downside is the possibility that this will cause problems for consumers and future parsers of wikitext, who have to reimplement the pipe trick for themselves; particularly if they are not expecting to find unexpanded links in the source. At the moment, having it in both places allows templates to work using the "in-parse" mode, while normal pages (and thus normal consumers) will always see the expanded version.

As it seems there is an overwhelming amount of support for removing as much as possible from the PST, I have attached a trivial patch to fix this issue. (anyone applying it will need to upgrade the parser tests that it breaks)
Comment 3 Niklas Laxström 2010-09-12 20:06:55 UTC
Another reason to get rid of it: it prevents saving certain kind of syntax (affecting for example translations at

Changing severity from enhancement to normal.
Comment 4 p858snake 2011-04-30 00:10:06 UTC
*Bulk BZ Change: +Patch to open bugs with patches attached that are missing the keyword*
Comment 5 Andre Klapper 2014-02-18 20:00:32 UTC
(In reply to Conrad Irwin from comment #2)
> Created attachment 7093 [details]
> A patch to fix this

patch -p0 > patch
patching file includes/parser/Parser.php
Reversed (or previously applied) patch detected!  Assume -R? [n] 
Apply anyway? [n] 
Skipping patch.
1 out of 1 hunk ignored -- saving rejects to file includes/parser/Parser.php.rej

Note You need to log in before you can comment on or make changes to this bug.