Last modified: 2014-09-24 01:23:40 UTC
We should keep the [[w:pipe trick|]] as it is entered instead of converting it to [[w:pipe trick|pipe trick]]. The pipe trick is clearer, easier to read, takes less space, and demonstrates to newer users that it is possible.
As was pointed above by Chris Wood, and at wikitech [1] by Aryeh Gregor, this trick should be part of the saved wikitext, not pre-converted on saving the page. [1] - http://lists.wikimedia.org/pipermail/wikitech-l/2009-July/044359.html
Created attachment 7093 [details] A patch to fix this I am not comfortable with fixing this myself, it seems like a very drastic change for very little benefit (particularly now the pipe trick works during normal parsing too). While the usabiltiy concern that it might be less easy to read the wikitext if the pipe trick is left, was countered by the argument that then people would find out about the pipe trick sooner, and thus increase productivity. The other downside is the possibility that this will cause problems for consumers and future parsers of wikitext, who have to reimplement the pipe trick for themselves; particularly if they are not expecting to find unexpanded links in the source. At the moment, having it in both places allows templates to work using the "in-parse" mode, while normal pages (and thus normal consumers) will always see the expanded version. As it seems there is an overwhelming amount of support for removing as much as possible from the PST, I have attached a trivial patch to fix this issue. (anyone applying it will need to upgrade the parser tests that it breaks)
Another reason to get rid of it: it prevents saving certain kind of syntax (affecting for example translations at translatewiki.net). Changing severity from enhancement to normal.
*Bulk BZ Change: +Patch to open bugs with patches attached that are missing the keyword*
(In reply to Conrad Irwin from comment #2) > Created attachment 7093 [details] > A patch to fix this patch -p0 > patch patching file includes/parser/Parser.php Reversed (or previously applied) patch detected! Assume -R? [n] Apply anyway? [n] Skipping patch. 1 out of 1 hunk ignored -- saving rejects to file includes/parser/Parser.php.rej
