Last modified: 2006-06-24 20:58:56 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 4990 - Trying to edit while blocked should act like "view source"
Trying to edit while blocked should act like "view source"
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Page editing (Other open bugs)
1.6.x
All All
: Normal normal with 3 votes (vote)
: ---
Assigned To: Nobody - You can work on this!
http://en.wikipedia.org/wiki/Wikipedi...
: patch-reviewed
: 5513 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2006-02-14 18:29 UTC by Cesar Eduardo Barros
Modified: 2006-06-24 20:58 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
A patch to show the source of the page (or edited version if block is triggered on save) under the block notice (2.83 KB, patch)
2006-06-24 16:10 UTC, Ilmari Karonen
Details

Description Cesar Eduardo Barros 2006-02-14 18:29:02 UTC
When trying to edit a protected page, it shows the wiki markup (the read-only
"view source" mode). The same should happen when the user is blocked, since the
end effect is the same (they cannot edit the page).
Comment 1 Netoholic 2006-02-14 22:58:02 UTC
Changing the edit tab to "View source" is a good suggestion. 
Additionally, auto-blocks should not be triggered by viewing the 
source.  Currently, if you are logged in, your IP is auto-blocked 
if you click the "Edit" link.
Comment 2 Cesar Eduardo Barros 2006-02-15 14:54:41 UTC
I believe the autoblock is supposed to trigger at the same time the message
saying you are blocked shows. If you show the message, you have to do an autoblock.
Comment 3 Netoholic 2006-02-15 20:27:37 UTC
(In reply to comment #2)
> I believe the autoblock is supposed to trigger at the same
> time the message saying you are blocked shows. If you show
> the message, you have to do an autoblock.

Right, but you only get the message ([[MediaWiki:Blockedtext]]) 
saying you are blocked when you click the "Edit" button.   My 
point is that we can avoid many auto-blocks by showing only 
the "View source" button to blocked users. If they click "View 
source", you show them blockedtext and the source, but no auto-
block.  If they hack the url and try to "action=edit", show them 
blockedtext and autoblock their IP.
Comment 4 Melancholie 2006-02-26 20:16:28 UTC
*** Bug 5106 has been marked as a duplicate of this bug. ***
Comment 5 Rob Church 2006-03-06 07:41:29 UTC
As bug 5106 comment 3 echoes; we can't do this for caching reasons.
Comment 6 Melancholie 2006-04-09 18:40:21 UTC
*** Bug 5513 has been marked as a duplicate of this bug. ***
Comment 7 Melancholie 2006-04-09 18:52:31 UTC
To see the wiki source maybe the following links work:
http://en.wikipedia.org/wiki/Main_Page?action=raw&ctype=text/css (only non-IE)
http://en.wikipedia.org/w/index.php?title=Main_Page&action=raw&ctype=text/css (even 
IE, but leads to a download when using IE)
Comment 8 Rob Church 2006-04-09 18:56:41 UTC
If a user hits edit while blocked, I see no harm in showing them the "blocked"
notice, and placing the read-only text source underneath it.
Comment 9 Marco 2006-04-09 19:39:05 UTC
then do so...it still needs a dev for this change.
Comment 10 Rob Church 2006-04-09 23:03:42 UTC
(In reply to comment #9)
> then do so...it still needs a dev for this change.

That would be why it's on my to-do list.
Comment 11 Melancholie 2006-04-11 00:35:37 UTC
Reopening this bug; see comment #8 til comment #10.
Comment 12 Matthew "mpt" Thomas 2006-05-21 04:04:11 UTC
This bug is mutually exclusive with bug 2508.
Comment 13 Alan Barrett 2006-06-18 12:04:09 UTC
An "action=viewsource" would also be nice.  Then we 
could hand-edit the URL to change "action=edit" to 
"action=viewsource" after we get a "User is blocked" 
message.
Comment 14 Ilmari Karonen 2006-06-24 16:10:38 UTC
Created attachment 2003 [details]
A patch to show the source of the page (or edited version if block is triggered on save) under the block notice
Comment 15 Ilmari Karonen 2006-06-24 16:19:34 UTC
Actually, fixing this bug is just a side effect of this patch.  The real reason
I wrote it is to stop IE users from losing their edits if their IP is blocked
while they are editing.
Comment 16 Rob Church 2006-06-24 20:58:56 UTC
Applied an adapted version to SVN trunk, r15013.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links