Last modified: 2013-07-25 07:04:02 UTC
The URLs (return URLs, etc.) that are provided to OpenID consumers and providers end up being invalid when $wgServer is protocol-relative.
https://gerrit.wikimedia.org/r/45474
1- Hi, is the problem now solved for you ? 2- Does E:OpenID now for you ?
Yes, the attached patch solves all of the problems (it now functions as a consumer and provider successfully).
Tyler is working on that (thank you)
Today I'm seeing an OpenID failure on an install that has $wgServer = "//" . $_SERVER["SERVER_NAME"]; Is that the same as this bug, or related?
(In reply to comment #5) > Today I'm seeing an OpenID failure on an install that has > > $wgServer = "//" . $_SERVER["SERVER_NAME"]; > > Is that the same as this bug, or related? Same bug. The issue is that since $wgServer is relative, the extension puts protocol-relative URLs in the <meta> tags for OpenID, which causes errors when these URLs are detected by the OpenID provider.
Looks like the fix has been languishing in gerrit for months -- what's happening there? Do you just need a reviewer?
(In reply to comment #6) > (In reply to comment #5) > > Today I'm seeing an OpenID failure on an install that has > > > > $wgServer = "//" . $_SERVER["SERVER_NAME"]; > > > > Is that the same as this bug, or related? > > Same bug. The issue is that since $wgServer is relative, the extension puts > protocol-relative URLs in the <meta> tags for OpenID, which causes errors > when > these URLs are detected by the OpenID provider. thanks, I was not aware, that this is the reason why openID on my two "instances" was broken. Will check the fix now.
For those being interested in the solution: a fix is now available and it would be really great, if all of you can confirm, that it really solves the problem. https://gerrit.wikimedia.org/r/#/c/45474/ This version is live on http://openid-wiki.instance-proxy.wmflabs.org/wiki/Main_Page and http://openid-wiki.instance-proxy.wmflabs.org and http://openid-wiki2.instance-proxy.wmflabs.org
https://gerrit.wikimedia.org/r/45474 (Gerrit Change I087a6eeeec1ea2206968e0cabb83b62c4275d570) | change APPROVED and MERGED [by Wikinaut]
fixed with https://gerrit.wikimedia.org/r/#/c/45474/