Last modified: 2013-07-25 07:04:02 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T46293, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 44293 - [BUG] OpenID URLs are invalid when $wgServer is relative
[BUG] OpenID URLs are invalid when $wgServer is relative
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
OpenID (Other open bugs)
master
All All
: High normal (vote)
: ---
Assigned To: T. Gries
:
Depends on:
Blocks: 9604
  Show dependency tree / graph
 
Reported: 2013-01-23 22:22 UTC by Tyler Romeo
Modified: 2013-07-25 07:04 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Tyler Romeo 2013-01-23 22:22:51 UTC 
The URLs (return URLs, etc.) that are provided to OpenID consumers and providers end up being invalid when $wgServer is protocol-relative.
Comment 1 Tyler Romeo 2013-01-23 22:23:20 UTC 
https://gerrit.wikimedia.org/r/45474
Comment 2 T. Gries 2013-01-23 22:27:18 UTC 
1- Hi, is the problem now solved for you ?
2- Does E:OpenID now for you ?
Comment 3 Tyler Romeo 2013-01-24 04:21:47 UTC 
Yes, the attached patch solves all of the problems (it now functions as a consumer and provider successfully).
Comment 4 T. Gries 2013-01-28 20:59:01 UTC 
Tyler is working on that (thank you)
Comment 5 Andrew Bogott 2013-05-09 22:07:30 UTC 
Today I'm seeing an OpenID failure on an install that has

$wgServer = "//" . $_SERVER["SERVER_NAME"];

Is that the same as this bug, or related?
Comment 6 Tyler Romeo 2013-05-10 14:59:35 UTC 
(In reply to comment #5)
> Today I'm seeing an OpenID failure on an install that has
> 
> $wgServer = "//" . $_SERVER["SERVER_NAME"];
> 
> Is that the same as this bug, or related?

Same bug. The issue is that since $wgServer is relative, the extension puts protocol-relative URLs in the <meta> tags for OpenID, which causes errors when these URLs are detected by the OpenID provider.
Comment 7 Andrew Bogott 2013-05-10 15:09:46 UTC 
Looks like the fix has been languishing in gerrit for months -- what's happening there?  Do you just need a reviewer?
Comment 8 T. Gries 2013-05-13 21:26:19 UTC 
(In reply to comment #6)
> (In reply to comment #5)
> > Today I'm seeing an OpenID failure on an install that has
> > 
> > $wgServer = "//" . $_SERVER["SERVER_NAME"];
> > 
> > Is that the same as this bug, or related?
> 
> Same bug. The issue is that since $wgServer is relative, the extension puts
> protocol-relative URLs in the <meta> tags for OpenID, which causes errors
> when
> these URLs are detected by the OpenID provider.

thanks, I was not aware, that this is the reason why openID on my two "instances" was broken.

Will check the fix now.
Comment 9 T. Gries 2013-05-14 19:32:44 UTC 
For those being interested in the solution:

a fix is now available and it would be really great, if all of you can confirm, that it really solves the problem.

https://gerrit.wikimedia.org/r/#/c/45474/

This version is live on

http://openid-wiki.instance-proxy.wmflabs.org/wiki/Main_Page and http://openid-wiki.instance-proxy.wmflabs.org and http://openid-wiki2.instance-proxy.wmflabs.org
Comment 10 Gerrit Notification Bot 2013-05-25 12:30:57 UTC 
https://gerrit.wikimedia.org/r/45474 (Gerrit Change I087a6eeeec1ea2206968e0cabb83b62c4275d570) | change APPROVED and MERGED [by Wikinaut]
Comment 11 T. Gries 2013-05-25 12:31:49 UTC 
fixed with https://gerrit.wikimedia.org/r/#/c/45474/
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links