Last modified: 2013-08-21 18:12:13 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T39141, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 37141 - Make it possible to create a message group for message keys of a banner
Make it possible to create a message group for message keys of a banner
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
CentralNotice (Other open bugs)
master
All All
: Normal normal (vote)
: ---
Assigned To: Ryan Kaldari
:
Depends on: 37147
Blocks: 36591
  Show dependency treegraph
 
Reported: 2012-05-27 14:07 UTC by Siebrand Mazeland
Modified: 2013-08-21 18:12 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Siebrand Mazeland 2012-05-27 14:07:38 UTC
As a user with right "centralnotice-admin", I can indicate that translatable strings for a central notice are made a message group in the Translate extension (analogous to translation of workflow states) so that copy/paste for translators is no longer needed.

Brief acceptance criteria:
1. Honor "Languages" set (as forced priority languages).
2. Simply use a checkbox in CN: "Use Translate extension" when there is content for all message keys in the banner definition. (step 3a).

Hook example: wfRunHooks( 'TranslatePostInitGroups', array( &$wgTranslateCC, &$deps, &$autoload ) );
Comment 1 Ryan Kaldari 2012-05-27 19:26:53 UTC
"1. Honor "Languages" set (as forced priority languages)."

Can you elaborate on this a bit. I'm not sure what it means.
Comment 2 Siebrand Mazeland 2012-09-18 14:28:35 UTC
I think Ryan Kaldari implemented this completely last week. Ryan, can you please check and close if done, or not what would need doing.
Comment 3 Ryan Kaldari 2012-09-18 17:24:24 UTC
This is done except for acceptance criteria #2. We should add a checkbox in the banner interface that activates use of the Translate extension. We obviously don't want to create message groups for every single banner, as this would quickly overrun the system. Unfortunately, this requires a minor schema change (to store the setting for the banner).
Comment 4 Matt Walker 2012-09-21 18:46:05 UTC
There is already a need for a minor schema change with the patch I made for priority languages. However, what I'm wondering though is what if we always created the groups but by default always set the priority language only to the creating users default language? 

Right now of course we can easily add the switch, but I'm imagining that, as our usage of translate in CN becomes more feature rich, maintaining easy switching between the two methods will become a nightmare.

Siebrand, can you comment on what the major disadvantages would be to always having the banner create message groups?
Comment 5 Matt Walker 2013-08-21 18:12:13 UTC
I'm pretty sure this was done... I'll mark it as fixed but feel free to reopen if I've missed something in here.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links