Last modified: 2012-05-03 02:45:56 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T35931, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 33931 - Missing dependency to mw.user
Missing dependency to mw.user
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
CentralNotice (Other open bugs)
unspecified
All All
: High major (vote)
: MW 1.19 version
Assigned To: Ryan Kaldari
: patch, patch-reviewed
Depends on:
Blocks: 31217
  Show dependency tree / graph
 
Reported: 2012-01-24 18:51 UTC by Rainer Rillke @commons.wikimedia
Modified: 2012-05-03 02:45 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add a dependency to /mediawiki/trunk/extensions/CentralNotice/special/SpecialBannerController.php (2.75 KB, patch)
2012-01-24 18:54 UTC, Rainer Rillke @commons.wikimedia 		Details
Add an attachment (proposed patch, testcase, etc.)

Description Rainer Rillke @commons.wikimedia 2012-01-24 18:51:29 UTC 
In MW 1.19 it fails under some circumstances due to a not-declarded dependency to mw.user.anonymous(). Patch follows.
Comment 1 Rainer Rillke @commons.wikimedia 2012-01-24 18:54:42 UTC 
Created attachment 9902 [details]
Add a dependency to /mediawiki/trunk/extensions/CentralNotice/special/SpecialBannerController.php

Add a dependency to /mediawiki/trunk/extensions/CentralNotice/special/SpecialBannerController.php

I think that's the most fast solution: Until the callback, other gadgets might have loaded the mw.user module and further deferring the XHR by waiting for mw.user might not be the best.

Evaluate yourself.
Comment 2 Ryan Kaldari 2012-01-25 01:07:26 UTC 
Fixed in r109977. Thanks for the patch!
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links