Last modified: 2005-02-25 05:59:04 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 335 - Various forms accept GET requests
Various forms accept GET requests
Product: MediaWiki
Classification: Unclassified
General/Unknown (Other open bugs)
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
Depends on: 1040
  Show dependency treegraph
Reported: 2004-09-03 03:23 UTC by Timwi
Modified: 2005-02-25 05:59 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Description Timwi 2004-09-03 03:23:32 UTC
Originally submitted by Brion Vibber (vibber)<a href="/help/icon_legend.php?context=user_wantsdonations&amp;user_id=446709&amp;return_to=%2F"><IMG src="" alt="Accepting Donations" border="0" width="16" height="16"></a>  2003-11-16 00:29

Most form-handling code in the wiki doesn't actually check 
whether its stuff came via a GET or POST request. For the 
most part this isn't a big deal, but for admin actions that 
have confirmation screens, it's probably not a good idea.

It's possible for instance to craft a URL that will delete a 
page or ban an IP address and trick a sysop into loading it 
(possibly disguised as an inline image, hidden iframe or 
other secondary URL) and performing the action.

It's more difficult to fake a POST request, although still 
possible; checking the referrer header to avoid constructed 
forms on other sites (potentially autosubmitted via 
javascript) might be a step to counter this.
Comment 1 Brion Vibber 2005-02-25 05:59:04 UTC
Most POSTable forms now check $wgRequest->wasPosted(), and admin & editing forms protect 
against off-site form submissions with a session-based token key.

Resolving as FIXED.

Note You need to log in before you can comment on or make changes to this bug.