Last modified: 2010-05-15 15:37:40 UTC
Please can a developer delete these three lines 351 ff in UserMailer.php if( !$timecorrection ) { # fail safe $timecorrection = '00:00'; } These lines - even when they were intended as a fail-safe - _break_ a potentially given $wgLocalTZoffset value, with which the sysop can force a certain offset of all time displays. Without the three lines, it will also correctly work in enotifs: * Users having a timecorrection _set_ in their preferences, receive enotifs with page edit times expressed in their local time * User w/o a timecorrection (i.e. empty field) receive enotif with the _local_ time (= servertime + $wgLocalTZoffset, as intended)
related to bugzilla http://bugzilla.wikipedia.org/show_bug.cgi?id=3305 and 454 (enotif) and 505 (timezone issues)
(In reply to comment #0) > Please can a developer delete these lines 351 ff in UserMailer.php > > if( !$timecorrection ) { > # fail safe > $timecorrection = '00:00'; > } > this part should be really removed, pls.
Created attachment 846 [details] Modified UserMailer.php I've proposed the modified version in the attachment.
(Please add wikibugs-l@wikipedia.org to the CC list when assigning bugs.)
Created attachment 891 [details] Actual patch This is the actual patch file, in the expected format; the previous one was the whole PHP script, as I didn't have access to my CVS client at the time.
Committed.
Whoo!
