Last modified: 2010-05-15 15:37:40 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T5307, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 3307 - UserMailer.php - needs a small correction
UserMailer.php - needs a small correction
Product: MediaWiki
Classification: Unclassified
General/Unknown (Other open bugs)
All All
: Normal normal (vote)
: ---
Assigned To: Rob Church
: patch, patch-need-review
Depends on:
Blocks: 1002
  Show dependency treegraph
Reported: 2005-08-30 16:53 UTC by T. Gries
Modified: 2010-05-15 15:37 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Modified UserMailer.php (12.76 KB, text/plain)
2005-09-02 07:56 UTC, Rob Church
Actual patch (797 bytes, patch)
2005-09-14 13:29 UTC, Rob Church

Description T. Gries 2005-08-30 16:53:20 UTC
Please can a developer delete these three lines 351 ff in UserMailer.php

     if( !$timecorrection ) {
           # fail safe
          $timecorrection = '00:00';

These lines - even when they were intended as a fail-safe - _break_ a
potentially given $wgLocalTZoffset value, with which the sysop can force a
certain offset of all time displays.

Without the three lines, it will also correctly work in enotifs:
* Users having a timecorrection _set_ in their preferences, receive enotifs with
page edit times expressed in their local time
* User w/o a timecorrection (i.e. empty field) receive enotif with the _local_
time (= servertime + $wgLocalTZoffset, as intended)
Comment 1 T. Gries 2005-08-30 16:56:51 UTC
related to bugzilla and 454
(enotif) and 505 (timezone issues)
Comment 2 T. Gries 2005-08-30 22:37:38 UTC
(In reply to comment #0)
> Please can a developer delete these lines 351 ff in UserMailer.php
>      if( !$timecorrection ) {
>            # fail safe
>           $timecorrection = '00:00';
>      }
this part should be really removed, pls.
Comment 3 Rob Church 2005-09-02 07:56:37 UTC
Created attachment 846 [details]
Modified UserMailer.php

I've proposed the modified version in the attachment.
Comment 4 Zigger 2005-09-06 02:12:15 UTC
(Please add to the CC list when assigning bugs.)
Comment 5 Rob Church 2005-09-14 13:29:09 UTC
Created attachment 891 [details]
Actual patch

This is the actual patch file, in the expected format; the previous one was the
whole PHP script, as I didn't have access to my CVS client at the time.
Comment 6 Niklas Laxström 2005-09-14 21:05:20 UTC
Comment 7 Rob Church 2005-09-14 21:06:38 UTC

Note You need to log in before you can comment on or make changes to this bug.