Last modified: 2012-11-11 12:13:00 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T30287, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 28287 - "Your Changes" box should be read-only
"Your Changes" box should be read-only
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Page editing (Other open bugs)
unspecified
All All
: Normal trivial (vote)
: ---
Assigned To: horcheram
: easy, patch, patch-need-review
: 31054 (view as bug list)
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2011-03-28 01:15 UTC by Trevor Parscal
Modified: 2012-11-11 12:13 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Test case (336 bytes, text/plain)
2011-04-21 19:17 UTC, horcheram 		Details
Patch to make "your text" textareas read-only (509 bytes, patch)
2011-05-14 21:04 UTC, MZMcBride 		Details
Add an attachment (proposed patch, testcase, etc.)

Description Trevor Parscal 2011-03-28 01:15:42 UTC 
When running into an edit conflict, the "your changes" box at the bottom which shows the version you submitted and got rejected is editable, making it easy for users to mistake it for the edit box, copy the conflicted change in and save, only for them to realize their changes were not applied. 

If the box is made read-only, this would be far less likely to happen.
Comment 1 horcheram 2011-04-21 19:17:03 UTC 
Created attachment 8438 [details]
Test case

To create an edit conflict to test for this bug, open a wiki article in one window of the browser.  Choose edit for the page and start editing.  

Open the same article in another window of the browser.  Choose edit for the page and start editing.   Hit Save Changes in the second window.

The original window open will trigger an edit conflict.
Comment 2 MZMcBride 2011-05-14 21:04:43 UTC 
Created attachment 8536 [details]
Patch to make "your text" textareas read-only

Patch against r88116. The "Your text" box shows up if $wgSpamRegex is triggered or if a user hits an edit conflict (showTextbox2 function in includes/EditPage.php). In either case, there's no input mechanism, so <textarea readonly=""> makes sense.
Comment 3 Emufarmers 2011-05-14 22:58:43 UTC 
Fixed in r88122.  Thank you for the patch!
Comment 4 db [inactive,noenotif] 2012-11-11 12:13:00 UTC 
*** Bug 31054 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links