Last modified: 2010-05-15 15:38:07 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 2824 - Diff's and literal compare of numbers fails
Diff's and literal compare of numbers fails
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
History/Diffs (Other open bugs)
1.5.x
All All
: Normal trivial with 1 vote (vote)
: ---
Assigned To: Nobody - You can work on this!
http://test.leuksman.com/index.php?ti...
:
Depends on:
Blocks: 349
  Show dependency treegraph
 
Reported: 2005-07-12 18:18 UTC by lɛʁi לערי ריינהארט
Modified: 2010-05-15 15:38 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
recovered first screen dump for bug 02824 (104.09 KB, image/jpeg)
2005-12-15 23:23 UTC, lɛʁi לערי ריינהארט
Details
recovered second screen dump for bug 02824 (110.73 KB, image/jpeg)
2005-12-15 23:24 UTC, lɛʁi לערי ריינהארט
Details

Description lɛʁi לערי ריינהארט 2005-07-12 18:18:58 UTC
Hallo!

See
http://jadesukka.homelinux.org:8180/betawiki/Image:Diffs_and_numbers_01.jpg
a diff in the preview
http://jadesukka.homelinux.org:8180/betawiki/Image:Diffs_and_numbers_02.jpg
a diff from history

bugzilla:2372
bugzilla:02372

bugzilla:65|65, bugzilla:2130|2130
bugzilla:00065|00065, bugzilla:02130|02130

bugzilla:2718
bugzilla:02718

are *not differentiated.
Note: I removed the wiki brakets because the examples are not at wikipedia:en .

Regards Reinhardt [[user:gangleri]]
Comment 1 Brion Vibber 2005-11-05 08:26:33 UTC
I can confirm it happens, but DifferenceEngine.php is too terrible for mere mortals to 
comprehend.
Comment 2 Rob Church 2005-11-06 15:02:20 UTC
Or, to put it another way, it's a mess.
Comment 3 lɛʁi לערי ריינהארט 2005-12-15 23:23:21 UTC
Created attachment 1195 [details]
recovered first screen dump for bug 02824

see bug 349 comment 5 
Bug 349: diff didn't highlight a change

After uploading both screen dumps I will mark this bug as dependend of bug
00349 and mark as FIXED.
Comment 4 lɛʁi לערי ריינהארט 2005-12-15 23:24:03 UTC
Created attachment 1196 [details]
recovered second screen dump for bug 02824
Comment 5 lɛʁi לערי ריינהארט 2005-12-20 08:04:05 UTC
REOPENed
see bug 349 comment 8
bug 349: diff didn't highlight a change
Comment 6 lɛʁi לערי ריינהארט 2006-02-22 12:06:54 UTC
from bug 349 comment 8
> http://en.wikipedia.org/w/index.php?title=Lakh&action=edit&oldid=6163130
> ... 30,000,000.
> http://en.wikipedia.org/w/index.php?title=Lakh&action=edit&oldid=6115828
> ... 30,00,000.
> is *not* covered by attachment.cgi id=1190
> 
> Here are more numbers separated with "," other countries are using ".". Please
> change the code that diff sees three "number strings" . Compare only sequences
> of characters between 0 and 9, do not include ",", ".", "e" or "E" as in 10E3.
> 
> Please note that only the testcases from
> bug 2824: diffs and literal compare of numbers fails
> are fixed. I will reopen bug 2824 because "30,000,000" is a valid number.

http://en.wikipedia.org/w/wiki.phtml?title=Lakh&diff=6163130&oldid=6115828
the original url from bug 349 is FIXED

Will tray to generate the test cases from bug 349 comment 8.
Comment 7 Brion Vibber 2006-02-22 19:40:06 UTC
Do not use anything on Wikimedia sites at this time for testing the internal
diff engine, as we're using an external diff engine now (wikidiff2).
Comment 8 Brion Vibber 2008-04-26 23:55:34 UTC
Seems to have been fixed some time ago.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links