Last modified: 2010-05-15 15:38:07 UTC
Hallo! See http://jadesukka.homelinux.org:8180/betawiki/Image:Diffs_and_numbers_01.jpg a diff in the preview http://jadesukka.homelinux.org:8180/betawiki/Image:Diffs_and_numbers_02.jpg a diff from history bugzilla:2372 bugzilla:02372 bugzilla:65|65, bugzilla:2130|2130 bugzilla:00065|00065, bugzilla:02130|02130 bugzilla:2718 bugzilla:02718 are *not differentiated. Note: I removed the wiki brakets because the examples are not at wikipedia:en . Regards Reinhardt [[user:gangleri]]
I can confirm it happens, but DifferenceEngine.php is too terrible for mere mortals to comprehend.
Or, to put it another way, it's a mess.
Created attachment 1195 [details] recovered first screen dump for bug 02824 see bug 349 comment 5 Bug 349: diff didn't highlight a change After uploading both screen dumps I will mark this bug as dependend of bug 00349 and mark as FIXED.
Created attachment 1196 [details] recovered second screen dump for bug 02824
REOPENed see bug 349 comment 8 bug 349: diff didn't highlight a change
from bug 349 comment 8 > http://en.wikipedia.org/w/index.php?title=Lakh&action=edit&oldid=6163130 > ... 30,000,000. > http://en.wikipedia.org/w/index.php?title=Lakh&action=edit&oldid=6115828 > ... 30,00,000. > is *not* covered by attachment.cgi id=1190 > > Here are more numbers separated with "," other countries are using ".". Please > change the code that diff sees three "number strings" . Compare only sequences > of characters between 0 and 9, do not include ",", ".", "e" or "E" as in 10E3. > > Please note that only the testcases from > bug 2824: diffs and literal compare of numbers fails > are fixed. I will reopen bug 2824 because "30,000,000" is a valid number. http://en.wikipedia.org/w/wiki.phtml?title=Lakh&diff=6163130&oldid=6115828 the original url from bug 349 is FIXED Will tray to generate the test cases from bug 349 comment 8.
Do not use anything on Wikimedia sites at this time for testing the internal diff engine, as we're using an external diff engine now (wikidiff2).
Seems to have been fixed some time ago.
