Last modified: 2012-03-18 06:04:18 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T30141, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 28141 - Remove obsolete code from/tidy up CommonSettings/InitialiseSettings
Remove obsolete code from/tidy up CommonSettings/InitialiseSettings
Status: RESOLVED FIXED
Product: Wikimedia
Classification: Unclassified
Site requests (Other open bugs)
unspecified
All All
: Low minor (vote)
: ---
Assigned To: Nobody - You can work on this!
: shell
Depends on: 35283
Blocks:
  Show dependency treegraph
 
Reported: 2011-03-21 00:08 UTC by Sam Reed (reedy)
Modified: 2012-03-18 06:04 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Sam Reed (reedy) 2011-03-21 00:08:21 UTC
CommonSettings.php:

// SiteMatrix hook for 1.16, obsolete in 1.17
$wgHooks['SiteMatrixGetPrivateAndFishbowlWikis'][] = 
'efGetPrivateAndFishbowlWikis';
function efGetPrivateAndFishbowlWikis( &$private, &$fishbowl ) {
    global $IP;
    $private = array_map( 'trim', file( "$IP/../private.dblist" ) );
    $fishbowl = array_map( 'trim', file( "$IP/../fishbowl.dblist" ) );
    return true;
}


and

// Old ones, being obsoleted by the ext above...
#function wfSetupSiteDefaultMessages() {
#    global  $wgMessageCache, $wgSiteDefaultMessages;
#    $wgMessageCache->addMessages( $wgSiteDefaultMessages );
#}
#$wgExtensionFunctions[] = 'wfSetupSiteDefaultMessages';


and

# obsolete - merged
#if( $wmgUseUniversalEditButton ) {
#    include "$IP/extensions/UniversalEditButton/UniversalEditButton.php";
#}

InitialiseSettings.php:

# obsolete, september 2006
#'wgOnlySysopMayMove' => array(
#    'default' => false,
#    'dewiki'  => true, # Report by sansculotte on #mediawiki, TS 2004-10-15
#    'enwiki' => true,
#    'frwiki' => true, # requested by hashar
#    'mediawikiwiki' => true,
#    'commonswiki' => true, # requested by Bdka on #wikimedia-tech, 2006-05-04
#    'enwiktionary' => true, # requested in beer parlour, 13 june 2006
#    'hewiki' => true,
#),

// Obsoleted by WikimediaMessages extension
'wgSiteDefaultMessages' => array(
    'default' => array(
        # Bug 11912
        'sitesupport-url' => 'http://wikimediafoundation.org/wiki/Donate',
        'sitesupport' => 'Donate',
    ),
),



etc etc
Comment 1 Mark A. Hershberger 2011-04-27 05:23:17 UTC
Lowering priority on this instead of assigning it to Sam (you're welcome ;) )
Comment 2 p858snake 2011-05-15 03:03:31 UTC
16:16 logmsgbot: reedy synchronized php-1.17/wmf-config/CommonSettings.php 'bug 28141'
16:16 logmsgbot: reedy synchronized php-1.17/wmf-config/CommonSettings.php 'bug 28141'
16:16 logmsgbot: reedy synchronized php-1.17/wmf-config/InitialiseSettings.php 'bug 28141'
16:14 logmsgbot: reedy synchronized php-1.17/wmf-config/InitialiseSettings.php 'bug 28141' 

Can this be closed out reedy?
Comment 3 Sam Reed (reedy) 2011-05-15 12:06:42 UTC
Need to see if there's other shit that should be removed

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links