Last modified: 2011-03-25 06:40:21 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 28071 - Upload wizard does gracefully handle no thumbnail errors
Upload wizard does gracefully handle no thumbnail errors
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
UploadWizard (Other open bugs)
unspecified
All All
: Normal enhancement (vote)
: ---
Assigned To: Neil Kandalgaonkar
:
Depends on:
Blocks: 27260
  Show dependency treegraph
 
Reported: 2011-03-16 00:15 UTC by Michael Dale
Modified: 2011-03-25 06:40 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Michael Dale 2011-03-16 00:15:19 UTC
it appears that the upload wizard does not support uploading videos it errors out with "thumbnail missing information" Additionally the thumbnail check does nothing and proceeds to set the image src to null.
Comment 1 Michael Dale 2011-03-23 00:04:58 UTC
Renamed title to reflect the error. The issue appears to be that the upload wizard has no error handling for when an asset is uploaded and it can't generate a thumbnail for that asset. http://commons.prototype.wikimedia.org/wiki/File:Working_menu.ogv for example uploads fine in the Special:Upload page, but dies in the Special:UploadWizard page
Comment 2 Michael Dale 2011-03-24 16:51:28 UTC
Neil were you able to get a  better idea of what the issue was when we recreated it on prototype?  I don't think it will be an issue for commons since it will have a working install of thumbnails. But it would be good to test before we deploy ;) 
I think all you need to do for this bug is possibly double the size of thumbnail proxy, and possibly put a try catch around the asset load call.
Comment 3 Neil Kandalgaonkar 2011-03-25 06:33:24 UTC
I think this is fixed as of r84730
Comment 4 Neil Kandalgaonkar 2011-03-25 06:40:21 UTC
(In reply to comment #3)
> I think this is fixed as of r84730

To be clear: 

Actually there *was* error handling if the thumbnail could not be generated. The server reports thumberror in that case.

In r84730 I fixed the case where the thumbnail URL is given to the client but it mysteriously 404s or has some other issue.

One reason could be the relatively low size allowed for thumbnails served via UploadStash; given how video previews currently work on MediaWiki it could be the case that 256K was not enough. Other people have asked for this limit to be raised, so I upped the maximum thumbnail size to 1MB in r84731.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links