Last modified: 2014-06-20 21:30:04 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T29397, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 27397 - Preview of JS/CSS pages should highlight the source code instead of using simple <pre> tags
Preview of JS/CSS pages should highlight the source code instead of using sim...
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
SyntaxHighlight (GeSHi) (Other open bugs)
unspecified
All All
: Low enhancement with 2 votes (vote)
: MW 1.24 version
Assigned To: Bartosz Dziewoński
:
Depends on: 64859
Blocks:
  Show dependency treegraph
 
Reported: 2011-02-14 12:40 UTC by Helder
Modified: 2014-06-20 21:30 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Helder 2011-02-14 12:40:07 UTC
Since bug 4801 was fixed, it is now possible to preview the source code of scripts and stylesheets when editing CSS and JS pages. Nonetheless, the source code is displayed in a <pre> instead of being highlighted (as happens e.g. after the page is saved).

It would be useful to have Geshi highlighting applied to the code during preview, because then the users wouldn't need to put <source> tags around the code (as in the URL above).
Comment 1 Bryan Tong Minh 2011-02-14 13:25:44 UTC
Changing component to Geshi.
Comment 2 Mark A. Hershberger 2011-02-14 19:46:15 UTC
I'm not sure this really has anything to do with Geshi, does it?  This would require previews to use Geshi, is all.
Comment 3 Roan Kattouw 2011-02-14 20:41:33 UTC
(In reply to comment #2)
> I'm not sure this really has anything to do with Geshi, does it?  This would
> require previews to use Geshi, is all.
Geshi is an extension, so previews using Geshi would have to be implemented in Geshi, not in core.
Comment 4 Roan Kattouw 2011-02-14 20:41:59 UTC
(In reply to comment #3)
> (In reply to comment #2)
> > I'm not sure this really has anything to do with Geshi, does it?  This would
> > require previews to use Geshi, is all.
> Geshi is an extension, so previews using Geshi would have to be implemented in
> Geshi, not in core.
...or in SyntaxHighlight, rather. Geshi is the highlighting library.
Comment 5 Phillip Patriakeas 2011-02-14 21:11:32 UTC
I recall reading a comment in another bug that this would require a new hook for extensions (I don't remember what bug it was, though, and I couldn't find the comment when I looked earlier)... Am I misremembering, or is that correct?
Comment 6 sheac 2012-05-04 22:32:04 UTC
This bug has not been touched in at least six months. With this in mind, I've been asked by the bugmeister to bump this bug's priority down for "High". Concerns can be addressed to mah@everybody.org.
Comment 7 Bartosz Dziewoński 2014-06-20 21:30:04 UTC
I just tested and this seems to have been fixed by the set of patches for bug 64859.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links