Last modified: 2014-11-17 10:36:12 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T29164, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 27164 - Decouple the edit toolbar: make the activator more re-usable
Decouple the edit toolbar: make the activator more re-usable
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
WikiEditor (Other open bugs)
unspecified
All All
: Normal enhancement with 1 vote (vote)
: ---
Assigned To: Trevor Parscal
:
Depends on:
Blocks: 27165
  Show dependency treegraph
 
Reported: 2011-02-04 20:39 UTC by Jan Paul Posma
Modified: 2014-11-17 10:36 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Jan Paul Posma 2011-02-04 20:39:57 UTC

    
Comment 1 Jan Paul Posma 2011-02-04 20:41:09 UTC
Oops, hit return by accident.

The toolbar should be decoupled from the edit page to allow applying it to an arbitrary textarea. This is required for extensions like InlineEditor.
Comment 2 MZMcBride 2011-02-04 20:45:22 UTC
This sounds like a duplicate of bug 26918 (or maybe of bug 26914 comment 4).
Comment 3 Jan Paul Posma 2011-02-04 22:33:51 UTC
No, that's about being able to select an editing interface in the global or user settings. What I'd like, is to be able to use the WikiEditor toolbar in other places. So this is purely about the toolbar, not about the editing interface.

For example, the toolbar could be used in my InlineEditor extension, or in LiquidThreads, or in any other place where wikitext can be used.
Comment 4 Trevor Parscal 2011-02-07 17:29:35 UTC
To be clear, the toolbar code is mostly very modular, and this is a use case we paid attention to in it's design. There are two components to the toolbar, the plugin and the activator. The configuration (what buttons are where, what they do, what the look like, what label text they use) is in the activator - ext.wikiEditor.toolbar. The code that takes that config and builds a toolbar from it is jquery.wikiEditor.toolbar.

There have been other requests, which I agree with, which propose to make the configuration more configurable. I just wanted to point out, that all that needs to happen is work to make the activator more re-usable. The jQuery extension is highly reusable, and can even be used more than once on a single page.
Comment 5 Jan Paul Posma 2011-02-08 22:54:26 UTC
Ah, great! I was under the impression that it wasn't as easy as that. In that case we can keep this bug to make the activator more re-usable, since you have had more requests for that. Thanks for the clarification!
Comment 6 Krinkle 2011-02-09 15:29:16 UTC
Please note that LiquidThreads does this already (in most cases replying somewhere puts up a textarea with the editor) - depending on how they did it this may be what this bug requests (thus FIXED or INVALID)
Comment 7 Jan Paul Posma 2011-02-26 18:34:41 UTC
Fixed in r82706.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links