Last modified: 2011-02-02 22:11:15 UTC
Per r81204 and r81205, it wouldn't be nice releasing extensions (and even more so on WMF used ones), to be having deprecated warnings everywhere in the 1.17 release
http://toolserver.org/~krinkle/wikimedia-svn-search/do-live.php?path=%2Ftrunk%2Fphase3&recursive=on&searchphrase=wfDeprecated×tamp=1296376151 All the wfDeprecated() calls in phase3, seems to be 39 methods that need exploring/checking for this and bug 27042
Database::newFromParams - 2 usages Database->escapeLike - 13 usages Database->immediateBegin - 2 usages in DSMW Being kicked off my computer, my little sister wants to play games ;) Will carry on later
Image::__construct - 5 usages SiteStats::admin - SMW wfEncryptPassword - 3 usages in auth wfLoadExtensionMessages - Doesn't warn in 1.17 userMailer - NewUserNotif LogReader::__construct - MetavidWiki LogViewer::__construct - MetavidWiki WikiError::__construct - SemanticForms WikiError::isError - 19 usages WikiErrorMsg::__construct - SemanticForms SpecialPage::addPage - 18 usages And that concludes the list. Obviously, this doesn't include any called via vodoo, or other unobvious ways, but gives us a reasonable idea of what's going on. A couple of them will be only warning in 1.18, so that needs paying attention to, but if it was set to start warning in 1.17, they need tidying up. (I know some people do tidy them up when they mark them as deprecated with a warning)
escapeLike done in r81220
wfEncryptPassword in r81240 userMailer in r81241 Database->immediateBegin in r81242 SiteStats::admin in r81243 TODO: Database::newFromParams - 2 usages Image::__construct - 5 usages wfLoadExtensionMessages - Doesn't warn in 1.17 LogReader::__construct - MetavidWiki LogViewer::__construct - MetavidWiki WikiError::__construct - SemanticForms WikiError::isError - 19 usages WikiErrorMsg::__construct - SemanticForms SpecialPage::addPage - 18 usages
Database::newFromParams in r81244 Image::__construct in r81245 TODO: LogReader::__construct - MetavidWiki LogViewer::__construct - MetavidWiki SpecialPage::addPage - 18 usages Nothing TODO: wfLoadExtensionMessages - Doesn't warn in 1.17 Backed out in r78094 from 1.17 WikiError::__construct - SemanticForms WikiError::isError - 19 usages WikiErrorMsg::__construct - SemanticForms
TODO: What are these replaced with? LogReader::__construct - MetavidWiki LogViewer::__construct - MetavidWiki SpecialPage::addPage - 18 usages r81248 uniwiki and Wikidata can go to hell. Nothing TODO: wfLoadExtensionMessages - Doesn't warn in 1.17 Backed out in r78094 from 1.17. Logged bug 27066 for the SF components WikiError::__construct - SemanticForms WikiError::isError - 19 usages WikiErrorMsg::__construct - SemanticForms
I'm guessing the LogReader/LogViewer stuff isn't a blocker for release... They were marked deprecated before 1.14 was branched. bug 27071 logged for that one.
What remains isn't really a blocker for release. Certainly not for deployment.
Marking RESOLVED FIXED as I look to have tidied everything up, and marked for backport where appropriate
