Last modified: 2012-12-17 12:29:15 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T27491, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 25491 - JS errors in sequencer
JS errors in sequencer
Status: RESOLVED FIXED
Product: mwEmbed
Classification: Unclassified
Sequence editor (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Michael Dale
:
: 26456 (view as bug list)
Depends on:
Blocks: 24415
  Show dependency treegraph
 
Reported: 2010-10-11 22:01 UTC by Derk-Jan Hartman
Modified: 2012-12-17 12:29 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Derk-Jan Hartman 2010-10-11 22:01:48 UTC
Was playing with the cats sequence today. I got the following errors. I think this was due to me trying to use the frame handles to resize the editor areas. (wasn't working). I was using Safari

jui.combined.min.js:71
TypeError: Result of expression '$.widget.prototype._trigger' [undefined] is not an object.
That line contains:


+($.browser.safari&&this.cssPosition=='fixed'?0:(this.cssPosition=='fixed'?-this.scrollParent.scrollLeft():scrollIsRootNode?0:scroll.scrollLeft())))};},_clear:function(){this.helper.removeClass("ui-draggable-dragging");if(this.helper[0]!=this.element[0]&&!this.cancelHelperRemoval)this.helper.remove();this.helper=null;this.cancelHelperRemoval=false;},_trigger:function(type,event,ui){ui=ui||this._uiHash();$.ui.plugin.call(this,type,[event,ui]);if(type=="drag")this.positionAbs=this._convertPositionTo("absolute");return $.widget.prototype._trigger.call(this,type,event,ui);},plugins:{},_uiHash:function(event){return{helper:this.helper,position:this.position,absolutePosition:this.positionAbs,offset:this.positionAbs};}}));$.extend($.ui.draggable,{version:"1.7.1",eventPrefix:"drag",defaults:{addClasses:true,appendTo:"parent",axis:false,cancel:":input,option",connectToSortable:false,containment:false,cursor:"auto",cursorAt:false,delay:0,distance:1,grid:false,handle:false,helper:"original",iframeFix:false,opacity:false,refreshPositions:false,revert:false,revertDuration:500,scope:"default",scroll:true,scrollSensitivity:20,scrollSpeed:20,snap:false,snapMode:"both",snapTolerance:20,stack:false,zIndex:false}});$.ui.plugin.add("draggable","connectToSortable",{start:function(event,ui){var inst=$(this).data("draggable"),o=inst.options,uiSortable=$.extend({},ui,{item:inst.element});inst.sortables=[];$(o.connectToSortable).each(function(){var sortable=$.data(this,'sortable');if(sortable&&!sortable.options.disabled){inst.sortables.push({instance:sortable,shouldRevert:sortable.options.revert});sortable._refreshItems();sortable._trigger("activate",event,uiSortable);}});},stop:function(event,ui){var inst=$(this).data("draggable"),uiSortable=$.extend({},ui,{item:inst.element});$.each(inst.sortables,function(){if(this.instance.isOver){this.instance.isOver=0;inst.cancelHelperRemoval=true;this.instance.cancelHelperRemoval=false;if(this.shouldRevert)this.instance.options.revert=true;this.instance._mouseStop(event);this.instance.options.helper=this.instance.options._helper;if(inst.options.helper=='original')
Comment 1 Michael Dale 2010-10-12 00:47:55 UTC
Sequencer should not use jui.combined.min.js rather should hard code the use of its own jquery ui lib since it uses jquery ui 1.8 components.... So its odd that it is using the older jQuery ui 1.7 from usability. 

This should be 'fixed' once the new resource loader comes out with jquery 1.8 and or I could add more delay to when sequencer code is parsed and included so that it 'for sure' overrides the old jQuery library. 

Not sure how well safari or chrome for that matter will work with the sequencer in general. I should probably put some warning that 'works best with firefox 4' once that comes out. 

I am going to mark this REMIND because it should work its self out as bug 24415 gets resolved ( resource loader deployment )
Comment 2 MZMcBride 2010-10-18 17:10:31 UTC
No need to mark this as "remind." Keep this open until the issue is resolved.
Comment 3 MZMcBride 2010-10-18 17:11:29 UTC
Shifting this from a dependency to a block so that this makes sense.
Comment 4 Michael Dale 2010-12-28 20:10:27 UTC
*** Bug 26456 has been marked as a duplicate of this bug. ***
Comment 5 Michael Dale 2010-12-29 03:35:28 UTC
Fixed in r79157 
Usability extension loads jQuery ui asynchronously so we have to wait for it to loaded before we override it.
Comment 6 Michael Dale 2011-01-09 22:37:27 UTC
update has gone out, once you shift refresh gadget should read "mwEmbed remote:
r183" and should load more consistently.
Comment 7 Andre Klapper 2012-12-17 12:29:15 UTC
(In reply to comment #6)
> update has gone out, once you shift refresh gadget should read "mwEmbed
> remote:
> r183" and should load more consistently.

Michael: So is this FIXED?

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links