Last modified: 2011-09-07 19:48:51 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T26758, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 24758 - Upload wizard: API errors that block progress on description page submission
Upload wizard: API errors that block progress on description page submission
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
UploadWizard (Other open bugs)
unspecified
Other other
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
: 26076 (view as bug list)
Depends on: 28577
Blocks: 27260
  Show dependency treegraph
 
Reported: 2010-08-11 18:24 UTC by Guillaume Paumier
Modified: 2011-09-07 19:48 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Guillaume Paumier 2010-08-11 18:24:13 UTC
When saving the description on Step 3 to proceed to step 4, the upload wizard is stuck on Step 3 with the spinner spinning.

It may be a browser compatibility issue, I've asked people experiencing this issue to provide additional information.
Comment 1 Neil Kandalgaonkar 2011-03-19 02:15:11 UTC
Will reconsider this bug to be about any and all API errors that can block progress on the description page.
Comment 2 Neil Kandalgaonkar 2011-03-21 19:27:44 UTC
One reason this happens: 

'badtoken' errors -- if session times out in between uploading and describing.

Solution -- wrap the final metadata POST in a "postWithApiEditToken" call as we do with initial upload. This will retry the post with a fresh token if it encounters a badtoken error.
Comment 3 Neil Kandalgaonkar 2011-03-21 19:32:52 UTC
(In reply to comment #2)

Except... we're already doing that? 
The badtoken error *should* be impossible... unfortunately so far can't replicate


> One reason this happens: 
> 
> 'badtoken' errors -- if session times out in between uploading and describing.
> 
> Solution -- wrap the final metadata POST in a "postWithApiEditToken" call as we
> do with initial upload. This will retry the post with a fresh token if it
> encounters a badtoken error.
Comment 4 Neil Kandalgaonkar 2011-03-21 20:20:37 UTC
Other errors that can occur
- renameerror: if you accidentally enter a title like "foo.jpg", the system will try to rename it to "foo.jpg.jpg". Strip extensions, or disallow them
Comment 5 Neil Kandalgaonkar 2011-03-25 21:39:36 UTC
*** Bug 26076 has been marked as a duplicate of this bug. ***
Comment 6 Neil Kandalgaonkar 2011-04-18 01:35:57 UTC
blocking on 28577 since it describes the need for blacklist checking (which this bug just alludes to)
Comment 7 Neil Kandalgaonkar 2011-04-21 18:30:20 UTC
This bug breaks down into several parts.

If an error occurs on the details page submission, it should work like it did with errors on the upload page submission.

1) - The UI should catch any and all errors.
Sort of done, but it doesn't do much with them now

2) - Removing the failed submissions should be possible.
Progress made on this with r85694, can now remove an upload from anywhere, especially at a deeds interface. Now needs interface for Description page errors.

3) - Retrying the failed submissions should be possible.

4) - Errors which can be fixed by fixing the title should open up the interface again for that, and allow resubmission.

5) - Errors with the title which can be avoided (such as Blacklist) should be surfaced earlier
Probably won't block on this for 1.0, as we have issues with TitleBlacklist that we don't understand now.
Comment 8 Neil Kandalgaonkar 2011-04-21 18:37:13 UTC
Oops, the previous comment for (2) should have linked to r86594
Comment 9 Bugmeister Bot 2011-08-19 19:12:34 UTC
Unassigning default assignments. http://article.gmane.org/gmane.science.linguistics.wikipedia.technical/54734
Comment 10 Neil Kandalgaonkar 2011-09-07 19:48:51 UTC
re: comment #7, points 1-5 have been implemented and bugs with each feature should be broken out when discovered

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links