Last modified: 2010-05-15 15:38:12 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 2439 - e-mail confirmation error message issues
e-mail confirmation error message issues
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Special pages (Other open bugs)
1.5.x
All All
: Normal normal with 1 vote (vote)
: ---
Assigned To: Nobody - You can work on this!
: patch
Depends on: 959
Blocks:
  Show dependency treegraph
 
Reported: 2005-06-17 21:41 UTC by T. Gries
Modified: 2010-05-15 15:38 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description T. Gries 2005-06-17 21:41:23 UTC
Two fixes are needed:

(A) In Languages.php, the string
confirmemail_sendfailed = ...... delete the _second_ sentence, delete: "Check
address for invalid characters."

This is a misleading text, because this error is shown, when the mail function
is not working at all - indenpendet on invalid characters, this can be due to a
mal-installed wiki or php on the server.

(B) In SpecialUserlogin.pgp:

change the two occurences of 
   $result->getMessage()
to
   $result->toString()

getMessage() was introduced I think, when WikiError.php was introduced recently,
but is now called to String().

Please can someone fix this soon ?
Comment 1 Brion Vibber 2005-06-17 23:22:46 UTC
First appears invalid; user couldn't do anything about a misconfigured server, but can do 
something about invalid characters. If something the user does could cause it and could be 
fixed by the user, it seems 100% appropriate to mention it there.

Second I've fixed, adding getMessage() back and using that preferentially.
Comment 2 T. Gries 2005-06-18 00:37:24 UTC
(In reply to comment #1)
> First appears invalid; user couldn't do anything about a misconfigured server,
but can do 
> something about invalid characters. If something the user does could cause it
and could be 
> fixed by the user, it seems 100% appropriate to mention it there.

Brion: your statement is in my opinion incorrect, as this text string can also
appear for errors NOT caused by the user. You can check this by forcing your
mail system to produce an error:

On http://www.wikipage.de/de it can be seen - the mail function is not working
and you can force this on your wiki, too - that even when the user has entered a
fully correct e-mail address, s/he sees the misleading message "...Check addres
for invalid characters.". This is due to the fact that your
Specialconfirmemail.php outputs that text string in LINE 50 for _any_ error of
UserMailer() in line (which can cause that message when UserMailer() is
reporting an error).

Perhaps I should have better proposed to (better) distinguish between the
different types of errors - in the specific case mentioned here, it would be
appropriate to say "..... or potentially, check for invalid characters in the
e-mail address."

Please do me a favour and invest some minutes, as I did for reporting this
problem which was brought forward to me a user, and I investigated in this (not
related to my Enotif stuff).

In my opinion, and we are back to discussion months before, the e-mail address
should be checked for a valid form before it is tried to confirm it. See
bugzilla 959 !!
Comment 3 T. Gries 2005-06-18 00:38:37 UTC
changed teh title; did not reopened that bug (in order not to make Brion angry
again.)
Comment 4 T. Gries 2005-06-18 00:54:11 UTC
I propose to change the text in Language.php:

confirmemail_sendfailed = "Could not send confirmation mail due to server
misconfiguration or invalid characters in e-mail address."

Brion, is this, what you've meant ?

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links