Last modified: 2010-05-15 15:38:12 UTC
Two fixes are needed: (A) In Languages.php, the string confirmemail_sendfailed = ...... delete the _second_ sentence, delete: "Check address for invalid characters." This is a misleading text, because this error is shown, when the mail function is not working at all - indenpendet on invalid characters, this can be due to a mal-installed wiki or php on the server. (B) In SpecialUserlogin.pgp: change the two occurences of $result->getMessage() to $result->toString() getMessage() was introduced I think, when WikiError.php was introduced recently, but is now called to String(). Please can someone fix this soon ?
First appears invalid; user couldn't do anything about a misconfigured server, but can do something about invalid characters. If something the user does could cause it and could be fixed by the user, it seems 100% appropriate to mention it there. Second I've fixed, adding getMessage() back and using that preferentially.
(In reply to comment #1) > First appears invalid; user couldn't do anything about a misconfigured server, but can do > something about invalid characters. If something the user does could cause it and could be > fixed by the user, it seems 100% appropriate to mention it there. Brion: your statement is in my opinion incorrect, as this text string can also appear for errors NOT caused by the user. You can check this by forcing your mail system to produce an error: On http://www.wikipage.de/de it can be seen - the mail function is not working and you can force this on your wiki, too - that even when the user has entered a fully correct e-mail address, s/he sees the misleading message "...Check addres for invalid characters.". This is due to the fact that your Specialconfirmemail.php outputs that text string in LINE 50 for _any_ error of UserMailer() in line (which can cause that message when UserMailer() is reporting an error). Perhaps I should have better proposed to (better) distinguish between the different types of errors - in the specific case mentioned here, it would be appropriate to say "..... or potentially, check for invalid characters in the e-mail address." Please do me a favour and invest some minutes, as I did for reporting this problem which was brought forward to me a user, and I investigated in this (not related to my Enotif stuff). In my opinion, and we are back to discussion months before, the e-mail address should be checked for a valid form before it is tried to confirm it. See bugzilla 959 !!
changed teh title; did not reopened that bug (in order not to make Brion angry again.)
I propose to change the text in Language.php: confirmemail_sendfailed = "Could not send confirmation mail due to server misconfiguration or invalid characters in e-mail address." Brion, is this, what you've meant ?
