Last modified: 2010-05-15 15:37:34 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 2275 - Search index improperly updated on page move
Search index improperly updated on page move
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Search (Other open bugs)
1.5.x
All All
: Normal normal with 1 vote (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2005-05-31 13:37 UTC by Brion Vibber
Modified: 2010-05-15 15:37 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
patch to initialize those variables (1.02 KB, patch)
2005-05-31 19:41 UTC, David Benbennick
Details

Description Brion Vibber 2005-05-31 13:37:04 UTC
Title::moveTo()'s search index updates are bogus at the moment; it's using
uninitialized page id vars. Should be easy to fix, but don't forget.
Comment 1 David Benbennick 2005-05-31 19:41:10 UTC
Created attachment 583 [details]
patch to initialize those variables

Later in the same function, the calls to
   new SearchUpdate( $oldid, $nt->getPrefixedDBkey() );
and
   new SearchUpdate( $newid, $this->getPrefixedDBkey(), '' );
look backwards.  Why is the new article title ($nt) used with the old ID?
Comment 2 Brion Vibber 2005-06-01 02:34:11 UTC
The variable names were poorly chosen which made this more confusing than it should be. :)
I've changed them to $pageid and $redirid, and moved the getArticleId()s around so it 
picks up the right values.

When a page is renamed, its page_id stays constant while its page_namespace and page_title 
fields change. A new page is created which redirects to it; this new page carries the old 
page_namespace and page_title values, but has a different page_id.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links