Last modified: 2010-05-15 15:37:34 UTC
Title::moveTo()'s search index updates are bogus at the moment; it's using uninitialized page id vars. Should be easy to fix, but don't forget.
Created attachment 583 [details] patch to initialize those variables Later in the same function, the calls to new SearchUpdate( $oldid, $nt->getPrefixedDBkey() ); and new SearchUpdate( $newid, $this->getPrefixedDBkey(), '' ); look backwards. Why is the new article title ($nt) used with the old ID?
The variable names were poorly chosen which made this more confusing than it should be. :) I've changed them to $pageid and $redirid, and moved the getArticleId()s around so it picks up the right values. When a page is renamed, its page_id stays constant while its page_namespace and page_title fields change. A new page is created which redirects to it; this new page carries the old page_namespace and page_title values, but has a different page_id.
