Last modified: 2012-04-19 21:43:17 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T24209, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 22209 - Toolbar : Indent button should indent each line
Toolbar : Indent button should indent each line
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
UsabilityInitiative (Other open bugs)
unspecified
All All
: Normal enhancement (vote)
: ---
Assigned To: Adam Miller
:
Depends on:
Blocks: 24493 36111
  Show dependency treegraph
 
Reported: 2010-01-21 10:43 UTC by Calcey QA
Modified: 2012-04-19 21:43 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Wiki_r61227_2010-01-21_OperaIndent.pdf (47.29 KB, application/pdf)
2010-01-21 10:43 UTC, Calcey QA
Details

Description Calcey QA 2010-01-21 10:43:40 UTC
Created attachment 6997 [details]
Wiki_r61227_2010-01-21_OperaIndent.pdf

Reporting against Babaco Release : r61227

Steps to Reproduce ::

1) Add some bullets to the editor
2) Select two bullets and click on ident
<<The last bullet selected get in to the first line>>


Expected Outcome::

Both selected bullets should indented correctly

Test Environment::

Opera/9.63 (Windows NT 6.0; U; en) Presto/2.1.1
Opera/9.80 (Windows NT 5.1; U; en) Presto/2.2.15 Version/10.00
Comment 1 Trevor Parscal 2010-01-26 01:09:52 UTC
Changing to enhancement - this is something we should probably do to improve our list tools as well.
Comment 2 Roan Kattouw 2010-01-26 13:47:05 UTC
Adam did this in r61493; would be nice to have for list tools too (I suggested this as well in a CR comment) but that's a one-line change for every button, so I'm closing this bug.
Comment 3 nkomura@wikimedia.org 2010-01-27 01:42:19 UTC
Go Adam!!!
Comment 4 Calcey QA 2010-01-27 07:36:58 UTC
Verified in r61537
The bug still there is in Opera

Opera/9.63 (Windows NT 6.0; U; en) Presto/2.1.1

Opera/9.80 (X11; Linux i686; U; en) Presto/2.2.15 Version /10.00
Comment 5 Roan Kattouw 2010-01-27 15:24:31 UTC
(In reply to comment #4)
> Verified in r61537
> The bug still there is in Opera
> 
> Opera/9.63 (Windows NT 6.0; U; en) Presto/2.1.1
> 
> Opera/9.80 (X11; Linux i686; U; en) Presto/2.2.15 Version /10.00

I fixed related code in r61576, could you try again?
Comment 6 Calcey QA 2010-02-01 05:37:37 UTC
verified in r61584

The problem still exits.
Comment 7 Roan Kattouw 2010-02-19 00:08:51 UTC
*** Bug 22574 has been marked as a duplicate of this bug. ***
Comment 8 DieBuche 2011-04-20 11:03:46 UTC
Looks like it got reverted. It's not in jquery.textselection
Comment 9 Roan Kattouw 2011-04-21 13:46:46 UTC
(In reply to comment #8)
> Looks like it got reverted. It's not in jquery.textselection
It seems the code got lost somehow, yes. Adam introduced the splitlines option in r61493, but it somehow didn't make it into the core version of jquery.textSelection . However, the part of r61493 that changed the toolbar config to pass 'splitlines':true for the indent button did survive somehow.

Reintroduced splitlines support in r86622, multi-line indent works now. Tested in FF4 and IE8.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links