Last modified: 2014-04-29 15:22:55 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 22195 - Improved error feedback for SVG thumbnail rendering
Improved error feedback for SVG thumbnail rendering
Status: REOPENED
Product: MediaWiki
Classification: Unclassified
File management (Other open bugs)
1.16.x
All All
: Low enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks: 41371
  Show dependency treegraph
 
Reported: 2010-01-20 18:39 UTC by aliter
Modified: 2014-04-29 15:22 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Comment 1 Platonides 2010-01-20 18:42:27 UTC
Wikimedia purposefully doesn't render svgs which include another images (in this case it is including [[Image:Friesengebietblank.png]]).
Comment 2 Roan Kattouw 2010-01-20 19:51:33 UTC
(In reply to comment #1)
> Wikimedia purposefully doesn't render svgs which include another images (in
> this case it is including [[Image:Friesengebietblank.png]]).

Still, we could do with a less cryptic error message and not show a blank thumbnail in the wikitext (try previewing [[File:Fryskgebiet.svg|thumb]]).
Comment 3 Platonides 2010-01-20 19:55:41 UTC
The svg is rendered asynchronously to the page rendering, so I don't see a clean way to do it. Perhaps adding a broken flag to image table?
Comment 4 Roan Kattouw 2010-01-20 19:59:19 UTC
(In reply to comment #3)
> The svg is rendered asynchronously to the page rendering, so I don't see a
> clean way to do it. Perhaps adding a broken flag to image table?

Yeah whatever code generates the thumbnail URL could notice the thumbnail is broken (somehow, maybe with that flag, maybe otherwise) and use client-side scaling instead.
Comment 5 Platonides 2010-01-20 20:03:15 UTC
We could change the g_error with a return NULL. Hopefully that would just render everything but the image.

However, reusers would be vulnerable.

http://svn.wikimedia.org/viewvc/mediawiki/trunk/debs/librsvg2/debian/patches/no-external-files.patch?view=markup
Comment 6 Derk-Jan Hartman 2010-11-04 04:23:55 UTC
Renaming this bug to be specifically about the error feedback.

The issue itself with external images is covered by bug 3537

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links