Last modified: 2010-05-15 15:33:54 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T4078, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 2078 - Pressing "preview" or "changes" button on edit page loses watch/unwatch tab


Summary:	Pressing "preview" or "changes" button on edit page loses watch/unwatch tab

Status:	RESOLVED FIXED

Product:	MediaWiki
Classification:	Unclassified
Component:	Interface (Other open bugs)
Version:	1.4.x
Hardware:	All All

Importance:	Normal minor (vote)
Target Milestone:	---
Assigned To:	Nobody - You can work on this!

URL:
Whiteboard:
Keywords:	patch, patch-need-review

Duplicates:	2183 (view as bug list)
Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2005-05-05 17:31 UTC by Zigger
Modified:	2010-05-15 15:33 UTC (History)
CC List:	1 user (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
REL1_4 patch for SkinTemplate.php (701 bytes, patch) 2005-07-10 16:34 UTC, Zigger	Details
HEAD patch for SkinTemplate.php (692 bytes, patch) 2005-07-10 16:35 UTC, Zigger	Details
Add an attachment (proposed patch, testcase, etc.)

Description Zigger 2005-05-05 17:31:12 UTC

On an edit page while logged in (with the monobook skin), pressing "Show
Preview" (or "Show Changes" in 1.5alpha1) results in a missing watch/unwatch tab
at the top.

This is a minor issue, as the checkbox is still available.

Comment 1 Brion Vibber 2005-05-15 20:50:25 UTC

*** Bug 2183 has been marked as a duplicate of this bug. ***

Comment 2 Zigger 2005-07-10 16:34:07 UTC

Created attachment 692 [details]
REL1_4 patch for SkinTemplate.php

fixes problem on 1.4 preview

Comment 3 Zigger 2005-07-10 16:35:39 UTC

Created attachment 693 [details]
HEAD patch for SkinTemplate.php

Fixes problem on 1.5 edit : both preview and show-diff.

Comment 4 Brion Vibber 2005-07-10 23:22:19 UTC

(above patch comments out an explicit check for action=submit) Is there a reason that condition is there in the first place?

Comment 5 Zigger 2005-07-11 01:29:12 UTC

The condition had been in SkinTemplate.php from the first version, but I've now
checked the older history from SkinPHPTal.php.  In 1.70.2.11 and 1.107, it was
changed from "... $action != 'edit' and $action != 'submit'" in a fix for bug
270.  Those conditions were present in the first version of SkinPHPTal.php and I
don't where to find previous history of the templated Monobook skin, if there is
any.

Other Monobook tabs do not have this condition.  Other skins do not suppress the
watch link.

Comment 6 Brion Vibber 2005-09-02 05:32:42 UTC

Committed to REL1_5 and HEAD.

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links