Last modified: 2011-12-04 01:56:50 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T18434, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 16434 - Pagination doesn't work on Special:PrefixIndex with no prefix
Pagination doesn't work on Special:PrefixIndex with no prefix
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Special pages (Other open bugs)
unspecified
All All
: Low normal with 1 vote (vote)
: ---
Assigned To: Brion Vibber
http://en.wiktionary.org/wiki/Wiktion...
: code-update-regression
: 16032 29413 32715 32790 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-11-23 02:31 UTC by ipatrol
Modified: 2011-12-04 01:56 UTC (History)
12 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description ipatrol 2008-11-23 02:31:03 UTC
I have found a small but annoying problem inthe appendix list. When I try to scroll through the list of  appendices, I find that the next page has only one entry-which, strangely begins with the letter G.
User:Mathmagic 00:40, 20 August 2008 (UTC)
(Copy of original report, this user is not related to the sender of this bug)
Comment 1 Chad H. 2009-02-06 22:04:25 UTC
Not sure what this is? Wiktionary has an "Appendix" namespace, but what do you mean by the "list of appendicies?" Are you refering to the PrefixIndex that [[Appendix:Contents]] links to, or the Appendix category? Can't do much without more info. Also, switching to "MediaWiki" issue since its probably not a problem with Wikimedia.

Suggest INVALID without more info...
Comment 2 Platonides 2009-02-06 22:14:24 UTC
I have understood it!

Go to Special:PrefxIndex and search on Appendix namespace for pages starting on anything
http://en.wiktionary.org/w/index.php?title=Special%3APrefixIndex&from=&namespace=100

It ends on 'Glossary of backgammon', and there's a 'Next page' link http://en.wiktionary.org/w/index.php?title=Special:PrefixIndex&from=Glossary_of_backgammon_terms&namespace=100

But that link shows pages beginning on 'Glossary of backgammon', instead of pages beginning on anything from 'Glossary of backgammon'. 

The expected page is probably similar to http://en.wiktionary.org/w/index.php?title=Special:AllPages&namespace=100&from=Glossary_of_backgammon_terms&to=List_of_Proto-Indo-European_roots%2Fb%CA%B0
Comment 3 Chad H. 2009-02-06 22:28:13 UTC
*** Bug 16032 has been marked as a duplicate of this bug. ***
Comment 4 Aaron Schulz 2009-02-24 16:33:06 UTC
Can't reproduce this
Comment 5 Chad H. 2009-02-24 16:35:44 UTC
I can, directly on the links provided by Platonides. If you click the first link he gave, it shows you Special:Prefixindex (ignore the firstHeading name, I think they customized it). You see a pagination link in the upper right corner that would *lead* you to believe it's the next page worth of results. However, it instead gives you that title as your prefix, not a 2nd page of results.
Comment 6 Danny B. 2009-02-24 16:37:36 UTC
(In reply to comment #4)
> Can't reproduce this

Check my description in duped bug.
Comment 7 Roan Kattouw 2009-02-24 16:41:58 UTC
(In reply to comment #4)
> Can't reproduce this
> 

I can. It works fine when you're using Prefixindex with an actual prefix, but when you blank the prefix box, click Go, then click Next page, you get this bug.

The cause seems to be that the Next page link doesn't include the &prefix=foo parameter, which is there when using a prefix but absent when not using one; adding &prefix= to the URL gives the expected result.
Comment 8 Aaron Schulz 2009-02-24 16:42:18 UTC
This seems to occur only if the given prefix is empty
Comment 9 Aaron Schulz 2009-03-03 19:58:23 UTC
Fixed in r47984
Comment 10 ipatrol 2009-03-21 15:56:45 UTC
The problem still exists, please try again.
Comment 11 Mike.lifeguard 2009-03-21 16:01:06 UTC
(In reply to comment #10)
> The problem still exists, please try again.
> 

r47984 isn't live - we're running r47457 currently.
Comment 12 Splarka 2009-04-03 23:32:49 UTC
Note for posterity: This introduced a new bug, as the 'from' parameter behavior was changed, but 'from' was still being used for the name of the input box field. So Special:Prefixindex/Foo was behaving differently than putting Foo in the text box. r48845 should have fixed this.
Comment 13 Danny B. 2011-03-10 14:00:20 UTC
Problem still exists.

See for instance http://cs.wikisource.org/wiki/Special:PrefixIndex/Category: and hit the "Next page" link (currently "Next page (František Xaver Šalda)") and it will take you to http://cs.wikisource.org/w/index.php?title=Speci%C3%A1ln%C3%AD:PrefixIndex&from=Franti%C5%A1ek_Xaver_%C5%A0alda&namespace=14 which is obviously totally wrong, because it should show all further categories starting from category František Xaver Šalda.

----

Adding code-update-regression keyword, because it *used to work properly* prior to 2008-10-19 when I reported the bug 16032, so you can use that date to find out which changes have been done to relevant code in those days.
Comment 14 Mark A. Hershberger 2011-03-10 22:27:39 UTC
The link http://en.wiktionary.org/w/index.php?title=Special%3APrefixIndex&from=&namespace=100 still shows the same problem.  Unlike in Roan's comment from 2 years ago, the problem still shows up on http://en.wiktionary.org/w/index.php?title=Special%3APrefixIndex&from=&namespace=100&prefix=

Danny, did you notice a change in this behavior recently? (e.g, past month or so, it was fine, but now it isn't.)
Comment 15 Platonides 2011-03-15 18:09:56 UTC
> Adding code-update-regression keyword, because it *used to work properly* prior
> to 2008-10-19 when I reported the bug 16032, so you can use that date to find
> out which changes have been done to relevant code in those days.

That was probably introduced in r39873 (making SpecialPrefixindex a class child of SpecialAllpages).
ialex, can you look at it?
Comment 16 Brion Vibber 2011-06-15 17:41:00 UTC
*** Bug 29413 has been marked as a duplicate of this bug. ***
Comment 17 Krinkle 2011-09-14 18:21:14 UTC
Problem still happening:

# http://translatewiki.net/w/i.php?title=Special:PrefixIndex/Template%3A
# Link "next" http://translatewiki.net/w/i.php?title=Special:PrefixIndex&from=Identical%2FLoading&namespace=10
# Shows only list item with [[Template:Identical/Loading]]
# Should instead show the next pages.
# Simply replacing "PrefixIndex" with "AllPages" gives the desired effect: http://translatewiki.net/w/i.php?title=Special:AllPages&from=Identical%2FLoading&namespace=10
Comment 18 Brion Vibber 2011-11-30 01:09:05 UTC
*** Bug 32715 has been marked as a duplicate of this bug. ***
Comment 19 Brion Vibber 2011-11-30 18:47:14 UTC
Lemme see if I can fix this up once and for all. :)
Comment 20 Brion Vibber 2011-11-30 22:27:51 UTC
Ok looks like there are two problems:

1) Special:Prefixindex uses 'from' to fill the prefix if there's no or empty prefix

2) wfArrayToCGI() strips out empty parameters, so if prefix is empty it doesn't even get passed through to the 'next' link.

I could fix 1 but be left with 2. Not sure what undoing the stripping in wfArrayToCgi() would do -- it's been this way since at least r34823
Comment 21 Chad H. 2011-11-30 22:30:43 UTC
(In reply to comment #20)
> Ok looks like there are two problems:
> 
> 1) Special:Prefixindex uses 'from' to fill the prefix if there's no or empty
> prefix
> 
> 2) wfArrayToCGI() strips out empty parameters, so if prefix is empty it doesn't
> even get passed through to the 'next' link.
> 
> I could fix 1 but be left with 2. Not sure what undoing the stripping in
> wfArrayToCgi() would do -- it's been this way since at least r34823

You could fix #1 by doing something hacky with a hidden input perhaps?

"Fixing" #2 sounds scary and liable to break Who Knows What.
Comment 22 Brion Vibber 2011-11-30 22:31:45 UTC
Actually I'm just going to use the namespace parameter. :P
Comment 23 Brion Vibber 2011-11-30 22:38:52 UTC
Fixed on trunk (for 1.19) in r104765.
Comment 24 Brion Vibber 2011-11-30 22:39:00 UTC
Fixed on trunk (for 1.19) in r104765.
Comment 25 Brion Vibber 2011-12-04 01:56:50 UTC
*** Bug 32790 has been marked as a duplicate of this bug. ***

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links